Review main Merged

83021[TASK] Show sender email address for mailtest in ext:install

Torben Hansen CR +2 V +2 Easy +6 −5 updated 02/21/24, 14:47

Commit message

In TYPO3 versions before v9, the mailtest showed the configured
sender email address. This has been removed due to a wrong fluid
variable usage with #88523

With this change, the sender email address is now shown again in
the mailtest. Additionally, a note is added to clarify, that not
receiving the test email could be due to spam filters or the
sender domain SPF settings.

The notice about the `defaultMailFromAddress` has been removed,
since it is already checked in `EnvironmentController`, that
the value is configured and a valid email address.

Finally, the fluid variable `queueIdentifier` introduced with
#100084 has been removed, since it is not used in the template.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 3

Files 2

Review log 1014

  1. Torben Hansen uploaded patch set 1 02/16/24, 18:21

  2. core-ci voted on patch set 1 V +1 02/16/24, 18:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53260

  3. Torben Hansen updated the commit message in patch set 2 V +1 02/19/24, 10:41

  4. Torben Hansen uploaded patch set 3 02/19/24, 10:43

  5. core-ci voted on patch set 2 V +1 02/19/24, 10:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53334

  6. core-ci voted on patch set 3 V +1 02/19/24, 10:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53335

  7. Oli Bartsch voted on patch set 3 CR +1 V +1 02/20/24, 21:41

  8. Andreas Kienast commented on patch set 3 CR -1 02/21/24, 07:50

    Something is missing here
  9. Torben Hansen updated the commit message in patch set 4 CR +1 V +1 02/21/24, 08:13

  10. Torben Hansen commented on patch set 4 02/21/24, 08:14

    Reply

    Done
  11. Andreas Kienast commented on patch set 4 CR +1 V +1 02/21/24, 08:20

    Reply

    Ah, a classic. The line starts with a # and is therefore interpreted as a comment. Been there, done that.
  12. core-ci voted on patch set 4 V +1 02/21/24, 08:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53402

  13. Oli Bartsch voted on patch set 4 CR +2 V +2 02/21/24, 14:47

  14. Oli Bartsch merged patch set 5 02/21/24, 14:47