Review main Merged Breaking

83026[!!!][TASK] Use DB-level GUID Type for TCA type=uuid

Sascha Nowak CR +2 V +2 Normal +77 −10 updated 11/24/25, 18:08

Commit message

This change modifies `DefaultTcaSchema` to set the
Doctrine DBAL Type `GUID` for `TCAtype=uuid` fields,
using native `UUID` in case of PostgresSql and the
fallback `CHAR(36)` for other dbms.

It's technically debatable if this is really breaking
and the decision to communicate it this way is based
on the reason to raise awareness of the change in the
default handling and the stricter restriction for the
field value lenght to match the constraints.

In case systems misused the field and entered invalid
UUID data they need to take care of it, production or
test code.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 4257

Show 2332 earlier messages
  1. Sascha Nowak uploaded patch set 1 02/17/24, 10:45

  2. core-ci voted on patch set 1 V -1 02/17/24, 10:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53276

  3. Sascha Nowak commented on patch set 1 02/17/24, 11:11

    I've check the failing tests and the identifier field is of type uuid but the test data used in ReactionsRepositoryTest_reactions.csv are random string and not valid uuid's
  4. Chris Müller commented on patch set 1 02/17/24, 16:14

    Isn't this breaking as the table definition changes at least for PostgreSQL?
  5. Sascha Nowak abandoned the change 08/01/24, 20:43

  6. Alexander Schnitzler commented on patch set 1 10/14/24, 18:29

    What's the reason for abandoning this patch? Besides being possibly breaking, was there a bigger issue with it? Not only PostgreSQL would benefit from this change. Having MariaDB and MySQL use a char(36) instead of a varchar would already be much appreciated. As much as the automatic TCA enrichment helps, it's a bit annoying to see it overriding definitions in ext_tables.sql files.
  7. Sascha Nowak commented on patch set 1 10/15/24, 03:55

    Reply

    It's pretty hard to know what people write into this column, like we do in the tests :) this could be breaking so it's not a bugfix. I will give it another try for 15.0 as we can introduce a braking change there.
  8. Alexander Schnitzler commented on patch set 1 10/15/24, 06:25

    Reply

    Can you please explain this a little more? Are there any actual use cases where people define a uuid field in the TCA and then don't store a guid? Besides the test, which are fixable. Is this an assessment of the core team?
  9. Sascha Nowak restored the change 12/06/24, 16:11

  10. Sascha Nowak uploaded patch set 2 V -1 12/06/24, 16:11

  11. core-ci voted on patch set 2 V -1 12/06/24, 16:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70716

  12. Sascha Nowak uploaded patch set 3 V -1 12/06/24, 16:36

  13. core-ci voted on patch set 3 V -1 12/06/24, 16:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70717

  14. Sascha Nowak uploaded patch set 4 V -1 12/06/24, 17:13

  15. core-ci voted on patch set 4 V +1 12/06/24, 17:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70718

  16. Sascha Nowak commented on patch set 4 CR +1 V +1 12/06/24, 17:29

    Reply

    Acknowledged

    Reply

    Ok let's give it another try for version 14 as a breaking change
  17. Stefan Bürk commented on patch set 4 12/08/24, 09:49

    Reply

    > As much as the automatic TCA enrichment helps, it's a bit annoying to see it overriding definitions in ext_tables.sql files. @git@alexanderschnitzler.de That is not true. DefaultTCASchema generation is only done if not defined earlier (ext_tables.sql + PSR14 event).
  18. Stefan Bürk commented on patch set 4 12/23/24, 17:46

    Going to have a look on this the next day for the impact / v14, depends on having eventually https://review.typo3.org/c/Packages/TYPO3.CMS/+/87584 in first. In any case we need to add the Doctrine DBAL UUID type to the `add type as commend type` like for the json field to have Doctrine DBAL `UUID` type in the readoout database schema and not "StringType" for non PostgreSQL afterwards.
    Not checked for PostgreSQL .. but should that not be `VARCHAR(36)` currently (at least for MySQL/MariaDB it is VARCHAR(36) ?
  19. Sascha Nowak rebased onto patch set 5 CR +1 V +1 12/23/24, 17:46

  20. core-ci voted on patch set 5 V +1 12/23/24, 17:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71575

  21. Benni Mack updated the commit message in patch set 6 V +1 03/25/25, 15:10

  22. core-ci voted on patch set 6 V +1 03/25/25, 15:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76270

  23. Benni Mack rebased onto patch set 7 V +1 03/26/25, 09:08

  24. Sascha Nowak uploaded patch set 8 03/26/25, 09:09

  25. Sascha Nowak commented on patch set 7 03/26/25, 09:10

    Reply

    Hey @stefan@buerk.tech did you found some time to have a look at this change?

    Reply

    Done
  26. core-ci voted on patch set 7 V +1 03/26/25, 09:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76358

  27. core-ci voted on patch set 8 V +1 03/26/25, 09:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76359

  28. Georg Ringer commented on patch set 8 03/26/25, 09:18

    if it is a feature, we need a feature.rst as well, otherwise change it to TASK
  29. Sascha Nowak updated the commit message in patch set 9 V +1 03/26/25, 09:31

  30. core-ci voted on patch set 9 V +1 03/26/25, 09:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76362

  31. Georg Ringer voted on patch set 9 CR +1 V +1 04/10/25, 20:19

  32. Stefan Bürk commented on patch set 9 CR -2 04/10/25, 20:33

    -2 .. this still needs work (pre-patch and adjustment) and is not ready. See comments and pre-patch is in the making ...
  1. Benni Mack marked it work in progress 04/11/25, 06:52

  2. Benni Mack commented on patch set 9 04/11/25, 06:52

    @stefan@buerk.tech that's why we should mark them as WIP :)
  3. Stefan Bürk commented on patch set 9 04/11/25, 11:58

    Reply

    ack.
  4. Benni Mack wrote 04/15/25, 11:52

    Removed cc Benni Mack.
  5. Sascha Nowak uploaded patch set 10 CR +1 V +1 11/08/25, 10:17

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  6. Sascha Nowak commented on patch set 10 11/08/25, 10:20

    This change is ready for review.

    Reply

    @stefan@buerk.tech it would be great to get this patch in 14.0. This patch is here for a very long time and I do not like to wait another 1.5 years 😊
  7. core-ci voted on patch set 10 V -1 11/08/25, 10:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88690

  8. Sascha Nowak uploaded patch set 11 V -1 11/08/25, 10:34

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  9. core-ci voted on patch set 11 V +1 11/08/25, 10:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88693

  10. Simon Schaufelberger voted on patch set 11 CR +1 V +1 11/08/25, 11:22

  11. Stefan Bürk rebased onto patch set 12 CR +1 V +1 11/11/25, 15:48

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  12. Stefan Bürk commented on patch set 12 CR -2 11/11/25, 15:49

    Reply

    It's not about this change. As mentioned a couple of times some things are missing and needed to be done as a pre-change. Done that now with 91556: [BUGFIX] Allow `UUID` in `ext_tables.sql` using Doctrine `GuidType` | https://review.typo3.org/c/Packages/TYPO3.CMS/+/91556
  13. core-ci voted on patch set 12 V +1 11/11/25, 15:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89032

  14. Stefan Bürk rebased onto patch set 13 V +1 11/24/25, 16:33

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  15. core-ci voted on patch set 13 V +1 11/24/25, 16:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90872

  16. Stefan Bürk uploaded patch set 14 V +1 11/24/25, 17:36

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  17. Stefan Bürk commented on patch set 14 CR 0 11/24/25, 17:38

    Reply

    Pre-changes is merged.

    Reply

    At least you have the ability to configure it using `ext_tables.sql` with the already merged pre-change. Removing -2 now from this change.
  18. Stefan Bürk voted on patch set 14 CR +1 V +1 11/24/25, 17:47

  19. core-ci voted on patch set 14 V +1 11/24/25, 17:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90877

  20. Sascha Nowak commented on patch set 14 11/24/25, 17:50

    Reply

    Thanks
  21. Garvin Hicking commented on patch set 15 CR +1 V +1 11/24/25, 17:54

    Published edit on patch set 14.
  22. Garvin Hicking voted on patch set 15 CR +1 V +1 11/24/25, 17:54

  23. core-ci voted on patch set 15 V +1 11/24/25, 18:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90880

  24. Stefan Bürk voted on patch set 15 CR +2 V +2 11/24/25, 18:08

  25. Stefan Bürk merged patch set 16 11/24/25, 18:08