83031[FEATURE] Provide full userdata in password recovery email in ext:backend
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Garvin Hicking +1
- Guido Schmechel +1
- Stefan Bürk +1
-
Verified V +2 Done
- Benni Mack +2
- Garvin Hicking +1
- Guido Schmechel +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 2
Review log 2428
Show 23 earlier messages
-
Torben Hansen uploaded patch set 1 02/18/24, 18:03
-
core-ci voted on patch set 1 V +1 02/18/24, 18:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53309
-
Thomas Hohn commented on patch set 1 02/21/24, 09:19
-
Thomas Hohn commented on patch set 1 02/21/24, 09:20
Just forget itPasswordReset.php:145ReplyDone -
Thomas Hohn voted on patch set 1 CR +1 02/21/24, 09:20
-
Garvin Hicking commented on patch set 1 02/21/24, 09:21
PasswordReset.php:131IMO we should not expose the "password" column here, to prevent that usage within a fluid template? -
Thomas Hohn commented on patch set 1 02/21/24, 09:23
PasswordReset.php:131ReplyIt's unset later in the code ..PasswordReset.php:145The $users should contain at least one element here - right - then the cast is not needed -
Garvin Hicking commented on patch set 1 02/21/24, 09:23
PasswordReset.php:131ReplyAh, I'm sorry, I missed the "unset" later on.PasswordReset.php:138I think most places in the core now do a "=== []" comparison, maybe adapt to this when it's touched? -
Torben Hansen uploaded patch set 2
CR +1V +102/22/24, 14:39 -
Torben Hansen commented on patch set 1 02/22/24, 14:40
PasswordReset.php:138ReplyDonePasswordReset.php:145ReplyDone -
Thomas Hohn voted on patch set 2 CR +1 02/22/24, 14:42
-
core-ci voted on patch set 2 V +1 02/22/24, 14:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53447
-
Garvin Hicking voted on patch set 2 CR +1 V +1 02/22/24, 15:38
-
Oli Bartsch commented on patch set 2 02/22/24, 17:17
Feature-103147-ProvideFullUserdataInPasswordRecoveryEmailInExtbackend.rst:16Could we mention that this is the `be_users` table? So devs are aware that this includes also any custom field, added to the table. -
Torben Hansen uploaded patch set 3
CR +1V +102/23/24, 08:25 -
Torben Hansen commented on patch set 3 02/23/24, 08:25
Feature-103147-ProvideFullUserdataInPasswordRecoveryEmailInExtbackend.rst:16ReplyDone -
Thomas Hohn voted on patch set 3 CR +1 V +1 02/23/24, 08:27
-
core-ci voted on patch set 3 V +1 02/23/24, 08:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53460
-
Josef Glatz voted on patch set 3 CR +1 V +1 03/06/24, 16:16
-
Garvin Hicking commented on patch set 3 CR +1 V +1 03/06/24, 21:58
Minor ReST nitpicks ;)Feature-103147-ProvideFullUserdataInPasswordRecoveryEmailInExtbackend.rst:14:html: or maybe just '{userdata}' (backticks)Feature-103147-ProvideFullUserdataInPasswordRecoveryEmailInExtbackend.rst:16:sql:Feature-103147-ProvideFullUserdataInPasswordRecoveryEmailInExtbackend.rst:22:html: or backticks -
Marvin Buchmann voted on patch set 3 CR +1 V +1 03/08/24, 09:34
-
Stefan Bürk uploaded patch set 4
CR +1V +103/08/24, 18:28 -
Stefan Bürk commented on patch set 4 CR +1 V +1 03/08/24, 18:29
Feature-103147-ProvideFullUserdataInPasswordRecoveryEmailInExtbackend.rst:14ReplyDoneFeature-103147-ProvideFullUserdataInPasswordRecoveryEmailInExtbackend.rst:16ReplyDoneFeature-103147-ProvideFullUserdataInPasswordRecoveryEmailInExtbackend.rst:22ReplyDone -
core-ci voted on patch set 4 V +1 03/08/24, 18:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54299
-
Garvin Hicking voted on patch set 4 CR +1 V +1 03/08/24, 18:35
-
Guido Schmechel voted on patch set 4 CR +1 V +1 03/10/24, 16:03
-
Benni Mack voted on patch set 4 CR +2 V +2 03/10/24, 23:14
-
Benni Mack merged patch set 5 03/10/24, 23:14
PasswordReset.php:145