Review 12.4 Merged

83033[TASK] Use first class closures for service provider factories

Benjamin Franzke CR +2 V +2 Hard +153 −127 updated 02/20/24, 14:02

Commit message

Adapt the service provider compiler to perform the same level of
optimization as for the array-based callable syntax:
We unroll the static closure into its static components (class name and
method name). That means the effective generated dependency injection
php code is the same as before with the gain of better DX.

Note that first class closures can only be used where methods of the
current scope are referenced, late state binding is not supported.
AbstractServiceProvider therefore keeps using array-based callable
syntax to be able to reference method scope of extending classes.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 11

Review log 69

  1. Benjamin Franzke uploaded patch set 1 02/19/24, 08:10

  2. core-ci voted on patch set 1 V -1 02/19/24, 08:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53326

  3. Benjamin Franzke uploaded patch set 2 V -1 02/19/24, 08:28

  4. core-ci voted on patch set 2 V -1 02/19/24, 08:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53327

  5. Benjamin Franzke uploaded patch set 3 V -1 02/19/24, 08:57

  6. core-ci voted on patch set 3 V +1 02/19/24, 09:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53331

  7. Stefan Bürk voted on patch set 3 CR +1 V +1 02/20/24, 14:01

  8. Benjamin Franzke voted on patch set 3 CR +2 V +2 02/20/24, 14:02

  9. Benjamin Franzke merged patch set 4 02/20/24, 14:02