83033[TASK] Use first class closures for service provider factories
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Stefan Bürk +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 11
- typo3/sysext/backend/Classes/ServiceProvider.php+14 −14
- typo3/sysext/core/Classes/DependencyInjection/ServiceProviderCompilationPass.php+13 −0
- typo3/sysext/core/Classes/Package/AbstractServiceProvider.php+1 −1
- typo3/sysext/core/Classes/ServiceProvider.php+59 −59
- typo3/sysext/core/Tests/Unit/DependencyInjection/Fixtures/TestServiceProvider.php+8 −0
- typo3/sysext/core/Tests/Unit/DependencyInjection/ServiceProviderCompilationPassTest.php+4 −0
- typo3/sysext/dashboard/Classes/ServiceProvider.php+10 −10
- typo3/sysext/extbase/Classes/ServiceProvider.php+5 −5
- typo3/sysext/fluid/Classes/ServiceProvider.php+3 −3
- typo3/sysext/frontend/Classes/ServiceProvider.php+4 −3
- typo3/sysext/install/Classes/ServiceProvider.php+32 −32
Review log 69
-
Benjamin Franzke uploaded patch set 1 02/19/24, 08:10
-
core-ci voted on patch set 1 V -1 02/19/24, 08:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53326
-
Benjamin Franzke uploaded patch set 2
V -102/19/24, 08:28 -
core-ci voted on patch set 2 V -1 02/19/24, 08:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53327
-
Benjamin Franzke uploaded patch set 3
V -102/19/24, 08:57 -
core-ci voted on patch set 3 V +1 02/19/24, 09:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53331
-
Stefan Bürk voted on patch set 3 CR +1 V +1 02/20/24, 14:01
-
Benjamin Franzke voted on patch set 3 CR +2 V +2 02/20/24, 14:02
-
Benjamin Franzke merged patch set 4 02/20/24, 14:02