Review main Merged

83045[TASK] Remove wizard component from workspaces management

Andreas Kienast CR +2 V +2 Normal +133 −113 updated 02/23/24, 08:23

Commit message

The wizard component was introduced in EXT:workspaces back then as the
`Modal` component was not able to keep the current window open as long
an action is running.

Since any action executed in the workspaces management module is not
wizard-esque, plain modal windows are used instead now. The usage of
the `Wizard` component is completely dropped.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Andreas Nedbal +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Andreas Nedbal +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1217

  1. Andreas Kienast uploaded patch set 1 02/20/24, 13:30

  2. Andreas Kienast commented on patch set 1 CR -2 02/20/24, 13:35

  3. core-ci voted on patch set 1 V -1 02/20/24, 13:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53378

  4. Andreas Kienast uploaded patch set 2 V -1 02/21/24, 06:13

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  5. core-ci voted on patch set 2 V -1 02/21/24, 06:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53396

  6. Andreas Kienast uploaded patch set 3 V -1 02/21/24, 06:28

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  7. Andreas Kienast voted on patch set 3 CR 0 02/21/24, 06:33

  8. core-ci voted on patch set 3 V +1 02/21/24, 06:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53397

  9. Benjamin Franzke uploaded patch set 4 V +1 02/22/24, 17:40

  10. core-ci voted on patch set 4 V +1 02/22/24, 17:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53451

  11. Benjamin Franzke commented on patch set 4 CR -1 02/22/24, 18:49

    on it

    backend.ts:893

    Needs to return a promise in order for the modal to stay opened. The modal API closes completed actions automatically. That also means me actually do not need to call modal.hideModal.
  12. Benjamin Franzke uploaded patch set 5 CR -1 V +1 02/22/24, 20:52

  13. Benjamin Franzke commented on patch set 5 02/22/24, 20:52

    backend.ts:893 Reply

    Done
  14. core-ci voted on patch set 5 V +1 02/22/24, 20:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53455

  15. Andreas Nedbal voted on patch set 5 CR +1 V +1 02/23/24, 00:06

  16. Andreas Kienast voted on patch set 5 CR +2 V +2 02/23/24, 08:23

  17. Andreas Kienast merged patch set 6 02/23/24, 08:23