Review main Merged

83047[TASK] Make form styling context aware

Benjamin Kott CR +2 V +2 Nightmare +3246 −1943 updated 08/21/24, 10:52

Commit message

We are dropping the Bootstrap CSS definitions for
all form stylings to have more control about the
styling of the form elements. From now on we are
shipping custom css adapted to our needs. The new
form element styling is context aware and adapts
to light and dark color schemes.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 1

Files 156

Show 136 more files

Review log 60113

Show 4488 earlier messages
  1. Benjamin Kott uploaded patch set 1 02/20/24, 15:04

  2. core-ci voted on patch set 1 V -1 02/20/24, 15:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53382

  3. Benjamin Kott uploaded patch set 2 V -1 02/21/24, 08:12

  4. core-ci voted on patch set 2 V +1 02/21/24, 08:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53400

  5. Benjamin Kott uploaded patch set 3 V +1 02/21/24, 08:29

  6. core-ci voted on patch set 3 V +1 02/21/24, 08:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53405

  7. Benjamin Kott uploaded patch set 4 V +1 02/21/24, 11:24

  8. core-ci voted on patch set 4 V +1 02/21/24, 11:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53416

  9. Benjamin Kott uploaded patch set 5 V +1 02/21/24, 15:32

  10. core-ci voted on patch set 5 V +1 02/21/24, 15:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53428

  11. Benjamin Kott uploaded patch set 6 V +1 02/21/24, 15:41

  12. core-ci voted on patch set 6 V +1 02/21/24, 15:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53429

  13. Benjamin Kott uploaded patch set 7 V +1 02/22/24, 09:41

  14. core-ci voted on patch set 7 V +1 02/22/24, 09:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53436

  15. Benjamin Kott uploaded patch set 8 V +1 02/22/24, 10:42

  16. core-ci voted on patch set 8 V +1 02/22/24, 10:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53442

  17. Benjamin Kott uploaded patch set 9 V +1 04/22/24, 13:12

  18. core-ci voted on patch set 9 V -1 04/22/24, 13:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56491

  19. Benjamin Kott uploaded patch set 10 V -1 06/21/24, 14:01

  20. core-ci voted on patch set 10 V -1 06/21/24, 14:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60028

  21. Benjamin Kott uploaded patch set 11 V -1 07/02/24, 06:10

  22. core-ci voted on patch set 11 V -1 07/02/24, 06:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60819

  23. Benjamin Kott uploaded patch set 12 V -1 07/03/24, 16:57

  24. core-ci voted on patch set 12 V -1 07/03/24, 17:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60918

  25. Benjamin Kott uploaded patch set 13 V -1 07/04/24, 06:24

  26. core-ci voted on patch set 13 V -1 07/04/24, 06:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60949

  27. Benjamin Kott uploaded patch set 14 V -1 07/04/24, 10:39

  28. core-ci voted on patch set 14 V -1 07/04/24, 10:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60962

  29. Benjamin Kott uploaded patch set 15 V -1 07/05/24, 06:10

  30. Benjamin Kott rebased onto patch set 16 07/05/24, 06:11

  31. core-ci voted on patch set 15 V -1 07/05/24, 06:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61015

  32. core-ci voted on patch set 16 V -1 07/05/24, 06:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61016

  33. Benjamin Kott uploaded patch set 17 V -1 07/08/24, 09:07

  34. core-ci voted on patch set 17 V -1 07/08/24, 09:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61169

  35. Benjamin Kott uploaded patch set 18 V -1 07/12/24, 12:18

  36. core-ci voted on patch set 18 V +1 07/12/24, 12:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61483

  37. Benjamin Kott uploaded patch set 19 V +1 07/15/24, 14:43

  38. Benjamin Kott uploaded patch set 20 07/15/24, 14:45

  39. core-ci voted on patch set 19 V +1 07/15/24, 14:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61592

  40. core-ci voted on patch set 20 V +1 07/15/24, 14:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61593

  41. Benjamin Kott uploaded patch set 21 V +1 07/16/24, 07:47

  42. core-ci voted on patch set 21 V +1 07/16/24, 07:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61614

  43. Benjamin Kott uploaded patch set 22 V +1 07/23/24, 09:26

  44. core-ci voted on patch set 22 V -1 07/23/24, 09:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61997

  45. Benjamin Kott uploaded patch set 23 V -1 07/23/24, 10:37

  46. core-ci voted on patch set 23 V -1 07/23/24, 10:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62001

  47. Jasmina Ließmann uploaded patch set 24 V -1 07/24/24, 20:59

  48. Jasmina Ließmann uploaded patch set 25 07/24/24, 21:02

  49. core-ci voted on patch set 24 V +1 07/24/24, 21:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62119

  50. core-ci voted on patch set 25 V +1 07/24/24, 21:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62120

  51. Jasmina Ließmann uploaded patch set 26 V +1 07/25/24, 12:22

  52. core-ci voted on patch set 26 V +1 07/25/24, 12:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62186

  53. Benjamin Kott uploaded patch set 27 V +1 08/07/24, 13:05

  54. core-ci voted on patch set 27 V +1 08/07/24, 13:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62996

  55. Benjamin Kott uploaded patch set 28 V +1 08/08/24, 12:45

  56. core-ci voted on patch set 28 V +1 08/08/24, 12:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63049

  57. Benjamin Kott uploaded patch set 29 V +1 08/08/24, 13:26

  58. core-ci voted on patch set 29 V +1 08/08/24, 13:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63054

  59. Benjamin Kott uploaded patch set 30 V +1 08/13/24, 13:28

  60. core-ci voted on patch set 30 V +1 08/13/24, 13:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63317

  61. Jasmina Ließmann uploaded patch set 31 V +1 08/13/24, 19:32

  62. core-ci voted on patch set 31 V +1 08/13/24, 19:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63338

  63. Benjamin Kott uploaded patch set 32 V +1 08/14/24, 12:30

  64. core-ci voted on patch set 32 V +1 08/14/24, 12:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63375

  65. Benjamin Kott uploaded patch set 33 V +1 08/15/24, 13:41

  66. core-ci voted on patch set 33 V +1 08/15/24, 13:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63494

  67. Benjamin Kott uploaded patch set 34 V +1 08/15/24, 13:54

  68. Benjamin Kott uploaded patch set 35 08/15/24, 13:58

  69. core-ci voted on patch set 34 V +1 08/15/24, 14:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63496

  70. core-ci voted on patch set 35 V +1 08/15/24, 14:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63497

  71. Benjamin Kott uploaded patch set 36 V +1 08/16/24, 09:42

  72. core-ci voted on patch set 36 V +1 08/16/24, 09:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63572

  73. Benjamin Kott uploaded patch set 37 V +1 08/16/24, 12:55

  74. core-ci voted on patch set 37 V +1 08/16/24, 13:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63578

  75. Benjamin Kott uploaded patch set 38 V +1 08/16/24, 13:52

  76. core-ci voted on patch set 38 V +1 08/16/24, 14:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63585

  77. Benjamin Kott uploaded patch set 39 V +1 08/19/24, 09:21

  78. core-ci voted on patch set 39 V -1 08/19/24, 09:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63757

  79. Benjamin Kott uploaded patch set 40 V -1 08/19/24, 12:41

  80. core-ci voted on patch set 40 V -1 08/19/24, 12:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63767

  81. Benjamin Kott uploaded patch set 41 V -1 08/19/24, 13:17

  82. core-ci voted on patch set 41 V -1 08/19/24, 13:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63773

  83. Benjamin Kott uploaded patch set 42 V -1 08/19/24, 13:29

  84. core-ci voted on patch set 42 V -1 08/19/24, 13:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63776

  85. Benjamin Kott uploaded patch set 43 V -1 08/20/24, 08:13

  86. core-ci voted on patch set 43 V +1 08/20/24, 08:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63811

  87. Benjamin Kott uploaded patch set 44 V +1 08/20/24, 14:53

  88. core-ci voted on patch set 44 V +1 08/20/24, 14:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63840

  1. Benjamin Kott uploaded patch set 45 V +1 08/21/24, 05:46

  2. core-ci voted on patch set 45 V +1 08/21/24, 05:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63877

  3. Benjamin Kott uploaded patch set 46 V +1 08/21/24, 07:01

  4. core-ci voted on patch set 46 V +1 08/21/24, 07:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63880

  5. Benjamin Kott uploaded patch set 47 V +1 08/21/24, 07:32

  6. core-ci voted on patch set 47 V +1 08/21/24, 07:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63881

  7. Benjamin Kott uploaded patch set 48 V +1 08/21/24, 07:47

  8. core-ci voted on patch set 48 V +1 08/21/24, 07:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63882

  9. Benjamin Franzke commented on patch set 47 08/21/24, 07:58

    _badges.scss:5

    stray </li>
  10. Benjamin Kott uploaded patch set 49 V +1 08/21/24, 08:04

  11. core-ci voted on patch set 49 V +1 08/21/24, 08:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63884

  12. Benjamin Kott uploaded patch set 50 V +1 08/21/24, 08:22

  13. core-ci voted on patch set 50 V +1 08/21/24, 08:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63885

  14. Benjamin Kott updated the commit message in patch set 51 V +1 08/21/24, 08:35

  15. core-ci voted on patch set 51 V +1 08/21/24, 08:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63886

  16. Benjamin Kott uploaded patch set 52 V +1 08/21/24, 08:43

  17. core-ci voted on patch set 52 V +1 08/21/24, 08:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63888

  18. Benjamin Franzke commented on patch set 48 08/21/24, 09:02

    _form-group.scss:9

    nitpick: `& + &`

    _form-section.scss:18

    `& + &`
  19. Benjamin Kott uploaded patch set 53 V +1 08/21/24, 09:04

  20. Benjamin Franzke commented on patch set 53 CR +1 V +1 08/21/24, 09:05

    yay!
  21. Benjamin Franzke commented on patch set 53 08/21/24, 09:06

    _badges.scss:5 Reply

    Done

    _form-group.scss:9 Reply

    Done

    _form-section.scss:18 Reply

    Done
  22. core-ci voted on patch set 53 V +1 08/21/24, 09:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63889

  23. Andreas Kienast voted on patch set 53 CR +2 V +2 08/21/24, 09:12

  24. Andreas Kienast merged patch set 54 08/21/24, 09:12

  25. Jasmina Ließmann commented on patch set 54 08/21/24, 10:52

    Unresolved

    I noticed some inconsistent behavior of form fields with .has-change class and created an issue for this: https://forge.typo3.org/issues/104679