Review main Merged

83048[BUGFIX] Preserve ordering of prefixed CKEditor5 CSS stylesheets

Benjamin Franzke CR +2 V +2 Easy +22 −12 updated 02/23/24, 09:22

Commit message

When CKEditor5 `contentsCss` configuration options references multiple
CSS, respective `fetch()` requests may finish in non-sequential order,
depending on server load and file size, causing intended CSS ordering
to break.

Ensure sequential ordering by waiting for all promises to be settled
via `Promise.allSettled()`.
It is guaranteed to return the promise status and values "in the order
of the promises passed, regardless of completion order":
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise/allSettled#return_value

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 2