83052[BUGFIX] Allow to configure RateLimiters in message consumer
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Garvin Hicking +1
-
Verified V +2 Done
- Benni Mack +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 3
Review log 3444
Show 1419 earlier messages
-
Sascha Nowak uploaded patch set 1 02/21/24, 06:07
-
core-ci voted on patch set 1 V +1 02/21/24, 06:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53395
-
Andreas Kienast commented on patch set 1 02/21/24, 07:23
In general I wonder whether this isn't a bugfix, especially since the ConsumeMessageCommand apparently had RateLimiter support prepared. IMO: make it a [BUGFIX], and rename the ReST to `12.x/Important-xxxxxxx`.Feature-103140-AllowToConfigureRateLimiters.rst:5`==================================================` (same length as headline) -
Sascha Nowak uploaded patch set 2
V +102/21/24, 08:12 -
Sascha Nowak commented on patch set 2 02/21/24, 08:12
Reply
DoneFeature-103140-AllowToConfigureRateLimiters.rst:5ReplyDone -
core-ci voted on patch set 2 V +1 02/21/24, 08:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53401
-
Benni Mack commented on patch set 2 02/21/24, 13:18
Important-103140-AllowToConfigureRateLimiters.rst:14This is an important rst, but with a _feature-10310 snippet and a "This feature". If this should go into 12.4, please use a wording appropriate to the use of Important, and ensure it is not a feature. -
Sascha Nowak uploaded patch set 3
V +102/21/24, 13:30 -
core-ci voted on patch set 3 V +1 02/21/24, 13:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53425
-
Chris Müller uploaded patch set 4
V +102/22/24, 18:26 -
core-ci voted on patch set 4 V +1 02/22/24, 18:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53454
-
Sascha Nowak commented on patch set 4 04/11/24, 05:43
Important-103140-AllowToConfigureRateLimiters.rst:14ReplyAcknowledged -
Oliver Klee updated the commit message in patch set 5
V +104/11/24, 07:33 -
core-ci voted on patch set 5 V +1 04/11/24, 07:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55738
-
Georg Ringer commented on patch set 5 04/11/24, 11:05
i would be in favor of naming that FEATURE and still backport it instead of misusing a bugfix -
Stefan Bürk voted on patch set 5 CR +1 V +1 04/16/24, 13:41
-
Jörg Bösche voted on patch set 5 CR +1 04/19/24, 12:27
-
Benni Mack commented on patch set 5 CR -1 04/19/24, 22:37
temp -1. need to have a closer look -
Sascha Nowak commented on patch set 5 07/12/24, 04:53
Reply
Good morning @benni@typo3.org, did you find your time to review the change.
-
Benni Mack voted on patch set 5 CR 0 07/12/24, 20:51
-
Stefan Bürk voted on patch set 5 CR 0 V 0 07/15/24, 21:49
-
Oliver Klee rebased onto patch set 6
CR +1V +109/16/24, 20:40 -
Sascha Nowak voted on patch set 6 CR +1 V +1 09/16/24, 20:40
-
core-ci voted on patch set 6 V +1 09/16/24, 20:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65926
-
Benni Mack updated the commit message in patch set 7
CR +1V +110/18/24, 13:50 -
Sascha Nowak uploaded patch set 8 12/06/24, 15:42
-
Sascha Nowak voted on patch set 8 CR +1 V +1 12/06/24, 15:42
-
core-ci voted on patch set 8 V +1 12/06/24, 15:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70713
-
Benni Mack voted on patch set 8 CR +1 V +1 03/25/25, 15:26
-
Andreas Kienast commented on patch set 8 CR -1 03/25/25, 15:36
Important-103140-AllowToConfigureRateLimiters.rst:41PHP array syntax in YAML? -
Andreas Kienast commented on patch set 8 03/25/25, 15:57
Important-103140-AllowToConfigureRateLimiters.rst:45This does not work as the class requires at least an identifier. We have another facade called `TYPO3\CMS\Core\RateLimiter\Storage\CachingFrameworkStorage`, which is however internal. I built a new factory entrypoint in `TYPO3\CMS\Core\RateLimiter\RateLimiterFactory` to drop the need of dealing with a storage here, but that class is internal as well (╯°□°)╯︵ ┻━┻ -
Sascha Nowak uploaded patch set 9
CR +1V +103/26/25, 07:06 -
Sascha Nowak commented on patch set 8 CR +1 V +1 03/26/25, 07:08
Important-103140-AllowToConfigureRateLimiters.rst:41ReplyHaha thanks for the hint. I copied it over 😂 as we use only the service.php in our projects.Important-103140-AllowToConfigureRateLimiters.rst:45ReplyI switch to InMemoryStorage which is the default of the RateLimiterFactory too. -
core-ci voted on patch set 9 V +1 03/26/25, 07:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76346
-
Benni Mack uploaded patch set 10
V +104/16/25, 10:45 -
Benni Mack voted on patch set 10 CR +1 V +1 04/16/25, 10:45
-
core-ci voted on patch set 10 V +1 04/16/25, 10:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77827
-
Stefan Bürk voted on patch set 10 CR +1 04/17/25, 15:57
-
Garvin Hicking commented on patch set 11
CR +1V +104/22/25, 06:29Published edit on patch set 10. -
Garvin Hicking voted on patch set 11 CR +1 V +1 04/22/25, 06:31
-
core-ci voted on patch set 11 V +1 04/22/25, 06:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78014
-
Benni Mack voted on patch set 11 CR +2 V +2 04/22/25, 12:33
-
Benni Mack merged patch set 12 04/22/25, 12:33
-
Lina Wolf commented on patch set 12 04/27/25, 10:01
I am not sure where to document this. See https://github.com/TYPO3-Documentation/Changelog-To-Doc/issues/1245 Is this part of the [Message bus](https://docs.typo3.org/permalink/t3coreapi:message-bus)?