Review main Merged

83052[BUGFIX] Allow to configure RateLimiters in message consumer

Sascha Nowak CR +2 V +2 Normal +77 −0 updated 04/27/25, 10:01

Commit message

This fix adds the missing configuration options for the rate limiters.
A "rate limiter" manages the frequency at which a particular messages,
such as an HTTP request or a login attempt, can occur. Rate limiting
serves as a protective mechanism to prevent services from being
overwhelmed by excessive usage, whether intentional or accidental, thus
ensuring their continued availability. Additionally, it proves
beneficial in regulating internal or outbound processes, such as
limiting the simultaneous processing of messages.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 3444

Show 1419 earlier messages
  1. Sascha Nowak uploaded patch set 1 02/21/24, 06:07

  2. core-ci voted on patch set 1 V +1 02/21/24, 06:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53395

  3. Andreas Kienast commented on patch set 1 02/21/24, 07:23

    In general I wonder whether this isn't a bugfix, especially since the ConsumeMessageCommand apparently had RateLimiter support prepared. IMO: make it a [BUGFIX], and rename the ReST to `12.x/Important-xxxxxxx`.

    Feature-103140-AllowToConfigureRateLimiters.rst:5

    `==================================================` (same length as headline)
  4. Sascha Nowak uploaded patch set 2 V +1 02/21/24, 08:12

  5. Sascha Nowak commented on patch set 2 02/21/24, 08:12

    Reply

    Done

    Feature-103140-AllowToConfigureRateLimiters.rst:5 Reply

    Done
  6. core-ci voted on patch set 2 V +1 02/21/24, 08:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53401

  7. Benni Mack commented on patch set 2 02/21/24, 13:18

    Important-103140-AllowToConfigureRateLimiters.rst:14

    This is an important rst, but with a _feature-10310 snippet and a "This feature". If this should go into 12.4, please use a wording appropriate to the use of Important, and ensure it is not a feature.
  8. Sascha Nowak uploaded patch set 3 V +1 02/21/24, 13:30

  9. core-ci voted on patch set 3 V +1 02/21/24, 13:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53425

  10. Chris Müller uploaded patch set 4 V +1 02/22/24, 18:26

  11. core-ci voted on patch set 4 V +1 02/22/24, 18:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53454

  12. Sascha Nowak commented on patch set 4 04/11/24, 05:43

    Important-103140-AllowToConfigureRateLimiters.rst:14 Reply

    Acknowledged
  13. Oliver Klee updated the commit message in patch set 5 V +1 04/11/24, 07:33

  14. core-ci voted on patch set 5 V +1 04/11/24, 07:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55738

  15. Georg Ringer commented on patch set 5 04/11/24, 11:05

    i would be in favor of naming that FEATURE and still backport it instead of misusing a bugfix
  16. Stefan Bürk voted on patch set 5 CR +1 V +1 04/16/24, 13:41

  17. Jörg Bösche voted on patch set 5 CR +1 04/19/24, 12:27

  18. Benni Mack commented on patch set 5 CR -1 04/19/24, 22:37

    temp -1. need to have a closer look
  19. Sascha Nowak commented on patch set 5 07/12/24, 04:53

    Reply

    Good morning @benni@typo3.org, did you find your time to review the change.
  1. Benni Mack voted on patch set 5 CR 0 07/12/24, 20:51

  2. Stefan Bürk voted on patch set 5 CR 0 V 0 07/15/24, 21:49

  3. Oliver Klee rebased onto patch set 6 CR +1 V +1 09/16/24, 20:40

  4. Sascha Nowak voted on patch set 6 CR +1 V +1 09/16/24, 20:40

  5. core-ci voted on patch set 6 V +1 09/16/24, 20:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65926

  6. Benni Mack updated the commit message in patch set 7 CR +1 V +1 10/18/24, 13:50

  7. Sascha Nowak uploaded patch set 8 12/06/24, 15:42

  8. Sascha Nowak voted on patch set 8 CR +1 V +1 12/06/24, 15:42

  9. core-ci voted on patch set 8 V +1 12/06/24, 15:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70713

  10. Benni Mack voted on patch set 8 CR +1 V +1 03/25/25, 15:26

  11. Andreas Kienast commented on patch set 8 CR -1 03/25/25, 15:36

    Important-103140-AllowToConfigureRateLimiters.rst:41

    PHP array syntax in YAML?
  12. Andreas Kienast commented on patch set 8 03/25/25, 15:57

    Important-103140-AllowToConfigureRateLimiters.rst:45

    This does not work as the class requires at least an identifier. We have another facade called `TYPO3\CMS\Core\RateLimiter\Storage\CachingFrameworkStorage`, which is however internal. I built a new factory entrypoint in `TYPO3\CMS\Core\RateLimiter\RateLimiterFactory` to drop the need of dealing with a storage here, but that class is internal as well (╯°□°)╯︵ ┻━┻
  13. Sascha Nowak uploaded patch set 9 CR +1 V +1 03/26/25, 07:06

  14. Sascha Nowak commented on patch set 8 CR +1 V +1 03/26/25, 07:08

    Important-103140-AllowToConfigureRateLimiters.rst:41 Reply

    Haha thanks for the hint. I copied it over 😂 as we use only the service.php in our projects.

    Important-103140-AllowToConfigureRateLimiters.rst:45 Reply

    I switch to InMemoryStorage which is the default of the RateLimiterFactory too.
  15. core-ci voted on patch set 9 V +1 03/26/25, 07:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76346

  16. Benni Mack uploaded patch set 10 V +1 04/16/25, 10:45

  17. Benni Mack voted on patch set 10 CR +1 V +1 04/16/25, 10:45

  18. core-ci voted on patch set 10 V +1 04/16/25, 10:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77827

  19. Stefan Bürk voted on patch set 10 CR +1 04/17/25, 15:57

  20. Garvin Hicking commented on patch set 11 CR +1 V +1 04/22/25, 06:29

    Published edit on patch set 10.
  21. Garvin Hicking voted on patch set 11 CR +1 V +1 04/22/25, 06:31

  22. core-ci voted on patch set 11 V +1 04/22/25, 06:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78014

  23. Benni Mack voted on patch set 11 CR +2 V +2 04/22/25, 12:33

  24. Benni Mack merged patch set 12 04/22/25, 12:33

  25. Lina Wolf commented on patch set 12 04/27/25, 10:01