83056[TASK] Add better PHPStan annotation for method getRepositoryClassName
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oliver Klee +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1115
-
Sebastian Sebastian uploaded patch set 1 02/21/24, 11:00
-
Sebastian Sebastian updated the commit message in patch set 2 02/21/24, 11:04
-
Sebastian Sebastian updated the commit message in patch set 3 02/21/24, 11:05
-
core-ci voted on patch set 1 V +1 02/21/24, 11:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53413
-
core-ci voted on patch set 2 V +1 02/21/24, 11:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53414
-
core-ci voted on patch set 3 V +1 02/21/24, 11:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53415
-
Oliver Klee voted on patch set 3 CR +1 V +1 02/21/24, 11:29
-
Andreas Kienast commented on patch set 3 CR -1 02/21/24, 11:50
There won't be another 13.0 release. -
Andreas Kienast updated the commit message in patch set 4
CR +1V +102/21/24, 11:50 -
Andreas Kienast commented on patch set 4 02/21/24, 11:51
Reply
Done -
Oliver Klee voted on patch set 4 CR +1 V +1 02/21/24, 11:53
-
core-ci voted on patch set 4 V +1 02/21/24, 11:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53417
-
Christian Kuhn commented on patch set 4 02/21/24, 13:04
note this in not critical for v11 in any way. but since this patch cherry-picks to v11 without troubles, is "just" an annotation fix, is obviously correct, and can not harm, we accept it for v11. -
Christian Kuhn voted on patch set 4 CR +2 V +2 02/21/24, 13:15
-
Christian Kuhn merged patch set 5 02/21/24, 13:15