Review main Merged

83056[TASK] Add better PHPStan annotation for method getRepositoryClassName

Sebastian Sebastian CR +2 V +2 Easy +1 −1 updated 02/21/24, 13:15

Commit message

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1115

  1. Sebastian Sebastian uploaded patch set 1 02/21/24, 11:00

  2. Sebastian Sebastian updated the commit message in patch set 2 02/21/24, 11:04

  3. Sebastian Sebastian updated the commit message in patch set 3 02/21/24, 11:05

  4. core-ci voted on patch set 1 V +1 02/21/24, 11:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53413

  5. core-ci voted on patch set 2 V +1 02/21/24, 11:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53414

  6. core-ci voted on patch set 3 V +1 02/21/24, 11:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53415

  7. Oliver Klee voted on patch set 3 CR +1 V +1 02/21/24, 11:29

  8. Andreas Kienast commented on patch set 3 CR -1 02/21/24, 11:50

    There won't be another 13.0 release.
  9. Andreas Kienast updated the commit message in patch set 4 CR +1 V +1 02/21/24, 11:50

  10. Andreas Kienast commented on patch set 4 02/21/24, 11:51

    Reply

    Done
  11. Oliver Klee voted on patch set 4 CR +1 V +1 02/21/24, 11:53

  12. core-ci voted on patch set 4 V +1 02/21/24, 11:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53417

  13. Christian Kuhn commented on patch set 4 02/21/24, 13:04

    note this in not critical for v11 in any way. but since this patch cherry-picks to v11 without troubles, is "just" an annotation fix, is obviously correct, and can not harm, we accept it for v11.
  14. Christian Kuhn voted on patch set 4 CR +2 V +2 02/21/24, 13:15

  15. Christian Kuhn merged patch set 5 02/21/24, 13:15