Review main Merged

83072[BUGFIX] Allow TCA resultArray modification via CustomFileControlsEvent

Benjamin Franzke CR +2 V +2 Normal +114 −2 updated 02/23/24, 12:20

Commit message

The event provides access to the `$resultArray` and documents
that it can be modified to set `javaScriptModules`, but missed
to take the resulting data into account.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1518

  1. Benjamin Franzke uploaded patch set 1 02/22/24, 07:30

  2. Andreas Kienast voted on patch set 1 CR +1 02/22/24, 07:35

  3. Daniel Siepmann voted on patch set 1 CR +1 V +1 02/22/24, 07:36

  4. Oli Bartsch commented on patch set 1 02/22/24, 07:36

    Let's add a test to ensure calling code receives the modified resultArray.
  5. core-ci voted on patch set 1 V +1 02/22/24, 07:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53433

  6. Benjamin Franzke commented on patch set 1 02/22/24, 09:54

    Reply

    Feel free to do so.
  7. Oli Bartsch uploaded patch set 2 CR +1 V +1 02/22/24, 17:15

  8. Oli Bartsch commented on patch set 2 CR +1 V +1 02/22/24, 17:15

    Reply

    Done.
  9. core-ci voted on patch set 2 V +1 02/22/24, 17:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53450

  10. Benjamin Franzke uploaded patch set 3 CR +1 V +1 02/23/24, 07:32

  11. Benjamin Franzke commented on patch set 3 02/23/24, 07:32

    Reply

    Thanks Oli!
  12. Benjamin Franzke commented on patch set 3 02/23/24, 07:35

    FilesControlContainerTest.php:60

    I've changed to `$this->get('service_container')`, since that is the correct "request" when asking for the symfony container instance that can be used to call `->set()`. Requesting ContainerInterface and assuming it is the symfony container is too generic. I'm aware that has been done many times in functionals, but since this commit holds my author name, I want this to be correct at least in here ;) (I'll adapt the other ones separately later)
  13. core-ci voted on patch set 3 V +1 02/23/24, 07:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53459

  14. Oli Bartsch commented on patch set 3 02/23/24, 08:51

    FilesControlContainerTest.php:60 Reply

    Ah, thanks for pointing this out. Will check "my" tests and adjust accordingly.
  15. Oli Bartsch voted on patch set 3 CR +1 V +1 02/23/24, 08:51

  16. Andreas Kienast voted on patch set 3 CR +1 V +1 02/23/24, 09:14

  17. Benjamin Franzke voted on patch set 3 CR +2 V +2 02/23/24, 09:22

  18. Benjamin Franzke merged patch set 4 02/23/24, 12:20