83072[BUGFIX] Allow TCA resultArray modification via CustomFileControlsEvent
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Oli Bartsch +1
- Andreas Kienast +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Oli Bartsch +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1518
-
Benjamin Franzke uploaded patch set 1 02/22/24, 07:30
-
Andreas Kienast voted on patch set 1 CR +1 02/22/24, 07:35
-
Daniel Siepmann voted on patch set 1 CR +1 V +1 02/22/24, 07:36
-
Oli Bartsch commented on patch set 1 02/22/24, 07:36
Let's add a test to ensure calling code receives the modified resultArray. -
core-ci voted on patch set 1 V +1 02/22/24, 07:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53433
-
Benjamin Franzke commented on patch set 1 02/22/24, 09:54
Reply
Feel free to do so. -
Oli Bartsch uploaded patch set 2
CR +1V +102/22/24, 17:15 -
Oli Bartsch commented on patch set 2 CR +1 V +1 02/22/24, 17:15
Reply
Done. -
core-ci voted on patch set 2 V +1 02/22/24, 17:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53450
-
Benjamin Franzke uploaded patch set 3
CR +1V +102/23/24, 07:32 -
Benjamin Franzke commented on patch set 3 02/23/24, 07:32
Reply
Thanks Oli! -
Benjamin Franzke commented on patch set 3 02/23/24, 07:35
FilesControlContainerTest.php:60I've changed to `$this->get('service_container')`, since that is the correct "request" when asking for the symfony container instance that can be used to call `->set()`. Requesting ContainerInterface and assuming it is the symfony container is too generic. I'm aware that has been done many times in functionals, but since this commit holds my author name, I want this to be correct at least in here ;) (I'll adapt the other ones separately later) -
core-ci voted on patch set 3 V +1 02/23/24, 07:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53459
-
Oli Bartsch commented on patch set 3 02/23/24, 08:51
FilesControlContainerTest.php:60ReplyAh, thanks for pointing this out. Will check "my" tests and adjust accordingly. -
Oli Bartsch voted on patch set 3 CR +1 V +1 02/23/24, 08:51
-
Andreas Kienast voted on patch set 3 CR +1 V +1 02/23/24, 09:14
-
Benjamin Franzke voted on patch set 3 CR +2 V +2 02/23/24, 09:22
-
Benjamin Franzke merged patch set 4 02/23/24, 12:20