Review main Merged

83073[TASK] Harden some DataHandler details

Christian Kuhn CR +2 V +2 Normal +75 −130 updated 02/27/24, 13:45

Commit message

Check $dataMap and $commandMap structure in start(),
type hint them to array. This is considered b/w
compatible since DH would have failed already when
the incoming array shape was funny, and the annotations
clearly stated an array must be given for a long
time already.

Minor adaptions throughout DH class to happify
phpstan a bit more.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Anja Leichsenring +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1115

  1. Christian Kuhn uploaded patch set 1 02/22/24, 08:58

  2. core-ci voted on patch set 1 V +1 02/22/24, 09:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53434

  3. Christian Kuhn uploaded patch set 2 V +1 02/27/24, 11:55

  4. core-ci voted on patch set 2 V +1 02/27/24, 12:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53637

  5. Christian Kuhn uploaded patch set 3 V +1 02/27/24, 12:18

  6. core-ci voted on patch set 3 V -1 02/27/24, 12:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53638

  7. Christian Kuhn uploaded patch set 4 V -1 02/27/24, 12:29

  8. Stefan Bürk voted on patch set 4 CR +1 V +1 02/27/24, 12:30

  9. core-ci voted on patch set 4 V +1 02/27/24, 12:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53639

  10. Anja Leichsenring voted on patch set 4 CR +1 V +1 02/27/24, 12:37

  11. Oliver Klee voted on patch set 4 V +1 02/27/24, 12:43

  12. Oliver Klee voted on patch set 4 CR +1 02/27/24, 12:43

  13. Christian Kuhn voted on patch set 4 CR +2 V +2 02/27/24, 12:53

  14. Christian Kuhn merged patch set 5 02/27/24, 12:53

  15. Benni Mack commented on patch set 5 02/27/24, 13:45

    thanks for that one!