83077[TASK] Test MathUtility::canBeInterpretedAsInteger() with bool
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- Stefan Bürk +1
- Mathias Brodala +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- Stefan Bürk +1
- Mathias Brodala +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1213
-
Christian Kuhn uploaded patch set 1 02/22/24, 11:34
-
core-ci voted on patch set 1 V +1 02/22/24, 11:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53446
-
Mathias Brodala commented on patch set 1 02/22/24, 11:41
-
Oliver Klee voted on patch set 1 CR +1 V +1 02/22/24, 11:43
-
Christian Kuhn commented on patch set 1 02/22/24, 11:44
MathUtilityTest.php:118Replyyes. that's why i added the tests to show this. -
Stefan Bürk voted on patch set 1 CR +1 V +1 02/22/24, 11:44
-
Mathias Brodala commented on patch set 1 02/22/24, 11:45
MathUtilityTest.php:118ReplyIs there already an intention to fix this IMO wrong behavior in a following change? Either bool should be rejected altogether or both values should be accepted as number. -
Christian Kuhn commented on patch set 1 02/22/24, 11:46
MathUtilityTest.php:118Replynote the impact when changing this is kinda problematic, which is why i don't tend to change that behavior currently. -
Mathias Brodala commented on patch set 1 02/22/24, 11:49
MathUtilityTest.php:118ReplyUnderstandable. I'll create a ticket for reference in any case. -
Christian Kuhn commented on patch set 1 02/22/24, 11:50
MathUtilityTest.php:118Replyagreed. -
Mathias Brodala commented on patch set 1 CR +1 V +1 02/22/24, 11:52
Verified by CI -
Christian Kuhn voted on patch set 1 CR +2 V +2 02/22/24, 11:56
-
Christian Kuhn merged patch set 2 02/22/24, 11:56
MathUtilityTest.php:118