Review main Merged

83080[DOCS] Correct field name in reaction's example

TYPO3com CR +2 V +2 Easy +4 −4 updated 02/23/24, 19:10

Commit message

To add a custom table to the list of tables,
the corresponding TCA field name "table_name"
has to be used.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1923

  1. TYPO3com uploaded patch set 1 02/22/24, 18:04

  2. Garvin Hicking commented on patch set 1 02/22/24, 18:09

    Thanks for the contribution! this tx_... schema is actually a convention that is followed through in all of the documentation, when extbase extensions are involved, like in the caption here. Could you otherwise describe more in depth why this notation is not suitable for you, maybe I'm misunderstanding something?
  3. core-ci voted on patch set 1 V +1 02/22/24, 18:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53452

  4. Chris Müller commented on patch set 1 02/22/24, 18:11

    Reply

    The fix is right, the second argument expects the TCA field. The table name is given in the third argument in the array.
  5. Chris Müller updated the commit message in patch set 2 V +1 02/22/24, 18:12

  6. core-ci voted on patch set 2 V +1 02/22/24, 18:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53453

  7. Chris Müller voted on patch set 2 CR +1 V +1 02/22/24, 18:20

  8. Daniel Schöne commented on patch set 2 02/22/24, 19:34

    Hi, I proposed the change. As Chris already mentioned: the 2nd argument is the field, the option should be appended to. Using "tx_myextension_domain_model_mytable" results in an exception, as this field does not exist in sys_reaction.
  9. Garvin Hicking commented on patch set 2 CR +1 V +1 02/22/24, 19:54

    Reply

    Acknowledged

    Reply

    Thanks, now I see it! sorry! 😅
  10. Daniel Schöne commented on patch set 2 CR +1 02/22/24, 20:08

    👍 thanks for reviewing
  11. Daniel Schöne voted on patch set 2 V +1 02/22/24, 20:14

  12. Oli Bartsch commented on patch set 2 CR -1 02/23/24, 13:29

    Index.rst:160

    While already on it. Let's use speaking array keys.
  13. Oli Bartsch uploaded patch set 3 CR +1 V +1 02/23/24, 13:31

  14. Oli Bartsch commented on patch set 3 CR +1 V +1 02/23/24, 13:34

    Index.rst:160 Reply

    Done
  15. core-ci voted on patch set 3 V +1 02/23/24, 13:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53495

  16. Garvin Hicking commented on patch set 3 CR +1 V +1 02/23/24, 14:01

    Nice change indeed!
  17. Oli Bartsch voted on patch set 3 CR +2 V +2 02/23/24, 14:09

  18. Oli Bartsch merged patch set 4 02/23/24, 14:18

  19. Daniel Schöne commented on patch set 4 02/23/24, 15:12

    Index.rst:160

    opening parenthesis missing

    Index.rst:161

    opening parenthesis missing
  20. Daniel Schöne commented on patch set 4 02/23/24, 15:14

    Index.rst:160 Reply

    sorry singe quote

    Index.rst:161 Reply

    parenthesis
  21. Garvin Hicking commented on patch set 4 02/23/24, 17:19

    Index.rst:161 Reply

    Oh damn, didn't spot that. This patch has been merged already. Would you want to create a follow-up patch to address the proper notation? Else I can offer to do that legwork. ;)
  22. Daniel Schöne commented on patch set 4 02/23/24, 17:32

    Added a patch via github. See https://review.typo3.org/c/Packages/TYPO3.CMS/+/83116 Didn't use gerrit for years, so that's the easiest way for me 😄
  23. Daniel Schöne commented on patch set 4 02/23/24, 19:10

    Index.rst:160 Reply

    Done

    Index.rst:161 Reply

    Done