83083[BUGFIX] Prevent PHP deprecation in getCookieName()
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Oliver Klee +1
- Andreas Kienast +1
-
Verified V +2 Done
- Oli Bartsch +2
- Oliver Klee +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1215
-
Oli Bartsch uploaded patch set 1 02/23/24, 09:27
-
core-ci voted on patch set 1 V +1 02/23/24, 09:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53464
-
Oliver Klee commented on patch set 1 02/23/24, 09:48
-
Oliver Klee commented on patch set 1 02/23/24, 09:48
Also, is 11.5 affected as well? -
Benni Mack commented on patch set 1 02/23/24, 09:56
don't we have the same problem in BackendUserAuthentication::getCookieName() ? -
Oli Bartsch uploaded patch set 2
V +102/23/24, 10:11 -
Oli Bartsch commented on patch set 2 02/23/24, 10:11
Reply
Yes, adjusted this method, too.Reply
Might be. However, i don't see this as a priority bugfix.FrontendUserAuthentication.php:171ReplyChanged to string comparison. -
core-ci voted on patch set 2 V -1 02/23/24, 10:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53470
-
Oliver Klee voted on patch set 2 CR +1 02/23/24, 10:26
-
Oli Bartsch uploaded patch set 3
CR +1V -102/23/24, 10:35 -
core-ci voted on patch set 3 V +1 02/23/24, 10:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53472
-
Andreas Kienast voted on patch set 3 CR +1 V +1 02/23/24, 10:51
-
Oliver Klee voted on patch set 3 CR +1 V +1 02/23/24, 10:59
-
Oli Bartsch voted on patch set 3 CR +2 V +2 02/23/24, 13:07
-
Oli Bartsch merged patch set 4 02/23/24, 13:07
FrontendUserAuthentication.php:171