Review main Merged

83085[BUGFIX] Do not render empty `eval` and `is_in` instructions

Andreas Kienast CR +2 V +2 Normal +45 −24 updated 03/21/24, 14:38

Commit message

This commit checks whether `eval` and `is_in` are not empty before they
are used as "input params" for the JavaScript part of the FormEngine.

Also, a plausibility check is added to ensure `eval=is_in` and a
non-falsy `is_in` configuration are given.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Markus Klein +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Markus Klein +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 2734

Show 79 earlier messages
  1. Andreas Kienast uploaded patch set 1 02/23/24, 09:50

  2. core-ci voted on patch set 1 V +1 02/23/24, 09:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53467

  3. Stefan Bürk voted on patch set 1 CR +1 02/23/24, 12:04

  4. Markus Klein commented on patch set 1 02/23/24, 12:20

    form-engine-validation.ts:222

    shouldn't this be extracted into a dedicated function? It's now 3x the same code
  5. Andreas Kienast commented on patch set 1 CR -1 02/23/24, 12:59

    form-engine-validation.ts:222 Reply

    Acknowledged
  6. Andreas Kienast uploaded patch set 2 CR +1 V +1 02/23/24, 13:01

  7. Andreas Kienast uploaded patch set 3 02/23/24, 13:04

  8. core-ci voted on patch set 2 V +1 02/23/24, 13:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53491

  9. Andreas Kienast uploaded patch set 4 02/23/24, 13:09

  1. core-ci voted on patch set 3 V +1 02/23/24, 13:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53492

  2. core-ci voted on patch set 4 V +1 02/23/24, 13:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53493

  3. Stefan Bürk voted on patch set 4 CR +1 V +1 02/23/24, 13:44

  4. Oli Bartsch commented on patch set 4 02/23/24, 15:12

    Any reason for not backporting this to 12.4?
  5. Andreas Kienast commented on patch set 4 02/23/24, 15:31

    Reply

    I'm not sure whether this is important enough for 12.4.
  6. Oli Bartsch commented on patch set 4 02/23/24, 20:55

    Reply

    I would say if the backport is not to complicated, let's do it. Otherwise I would also be fine to skip. As you like.
  7. Andreas Kienast updated the commit message in patch set 5 CR +1 V +1 02/26/24, 07:19

  8. Andreas Kienast commented on patch set 5 02/26/24, 07:19

    Reply

    Done
  9. core-ci voted on patch set 5 V +1 02/26/24, 07:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53564

  10. Markus Klein voted on patch set 5 CR +1 02/26/24, 07:46

  11. Anja Leichsenring voted on patch set 5 CR +1 V +1 03/08/24, 13:12

  12. Andreas Kienast uploaded patch set 6 CR +1 V +1 03/14/24, 08:34

  13. core-ci voted on patch set 6 V +1 03/14/24, 08:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54519

  14. Markus Klein voted on patch set 6 CR +1 V +1 03/14/24, 16:44

  15. Oliver Hader commented on patch set 6 03/15/24, 10:58

    InputTextElement.php:137

    Can you please add a comment here about that constraint (that both need to be set - `is_in` in `eval` and in addition as property on the same level)? Thx

    InputTextElement.php:141

    `$evalList = array_diff($evalList, ['is_in']);`?
  16. Andreas Kienast commented on patch set 6 CR -1 03/19/24, 07:11

    InputTextElement.php:137 Reply

    Acknowledged

    InputTextElement.php:141 Reply

    Acknowledged
  17. Andreas Kienast uploaded patch set 7 CR +1 V +1 03/19/24, 07:15

  18. core-ci voted on patch set 7 V +1 03/19/24, 07:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54674

  19. Markus Klein voted on patch set 7 CR +1 03/19/24, 09:41

  20. Markus Klein commented on patch set 7 03/19/24, 09:47

    InputTextElement.php:149

    Thought: Why do we implode the evalList here only to explode it in JS again? Maybe I'm missing something?
  21. Andreas Kienast commented on patch set 7 03/19/24, 11:38

    InputTextElement.php:149 Reply

    It has been like this since the initial introduction in v7. I also thought about changing this, but it's breaking for 3rd party integrations. We could do this with a TCA migration in place, but I'd consider such change not beneficial enough.
  22. Markus Klein voted on patch set 7 V +1 03/19/24, 14:52

  23. Oli Bartsch voted on patch set 7 CR +1 V +1 03/21/24, 13:24

  24. Andreas Kienast voted on patch set 7 CR +2 V +2 03/21/24, 14:25

  25. Andreas Kienast merged patch set 8 03/21/24, 14:38