83085[BUGFIX] Do not render empty `eval` and `is_in` instructions
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Oli Bartsch +1
- Markus Klein +1
-
Verified V +2 Done
- Andreas Kienast +2
- Oli Bartsch +1
- Markus Klein +1
- core-ci +1 CI
Issues 1
Files 3
Review log 2734
Show 79 earlier messages
-
Andreas Kienast uploaded patch set 1 02/23/24, 09:50
-
core-ci voted on patch set 1 V +1 02/23/24, 09:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53467
-
Stefan Bürk voted on patch set 1 CR +1 02/23/24, 12:04
-
Markus Klein commented on patch set 1 02/23/24, 12:20
-
Andreas Kienast commented on patch set 1 CR -1 02/23/24, 12:59
form-engine-validation.ts:222ReplyAcknowledged -
Andreas Kienast uploaded patch set 2
CR +1V +102/23/24, 13:01 -
Andreas Kienast uploaded patch set 3 02/23/24, 13:04
-
core-ci voted on patch set 2 V +1 02/23/24, 13:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53491
-
Andreas Kienast uploaded patch set 4 02/23/24, 13:09
-
core-ci voted on patch set 3 V +1 02/23/24, 13:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53492
-
core-ci voted on patch set 4 V +1 02/23/24, 13:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53493
-
Stefan Bürk voted on patch set 4 CR +1 V +1 02/23/24, 13:44
-
Oli Bartsch commented on patch set 4 02/23/24, 15:12
Any reason for not backporting this to 12.4? -
Andreas Kienast commented on patch set 4 02/23/24, 15:31
Reply
I'm not sure whether this is important enough for 12.4. -
Oli Bartsch commented on patch set 4 02/23/24, 20:55
Reply
I would say if the backport is not to complicated, let's do it. Otherwise I would also be fine to skip. As you like. -
Andreas Kienast updated the commit message in patch set 5
CR +1V +102/26/24, 07:19 -
Andreas Kienast commented on patch set 5 02/26/24, 07:19
Reply
Done -
core-ci voted on patch set 5 V +1 02/26/24, 07:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53564
-
Markus Klein voted on patch set 5 CR +1 02/26/24, 07:46
-
Anja Leichsenring voted on patch set 5 CR +1 V +1 03/08/24, 13:12
-
Andreas Kienast uploaded patch set 6
CR +1V +103/14/24, 08:34 -
core-ci voted on patch set 6 V +1 03/14/24, 08:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54519
-
Markus Klein voted on patch set 6 CR +1 V +1 03/14/24, 16:44
-
Oliver Hader commented on patch set 6 03/15/24, 10:58
InputTextElement.php:137Can you please add a comment here about that constraint (that both need to be set - `is_in` in `eval` and in addition as property on the same level)? ThxInputTextElement.php:141`$evalList = array_diff($evalList, ['is_in']);`? -
Andreas Kienast commented on patch set 6 CR -1 03/19/24, 07:11
InputTextElement.php:137ReplyAcknowledgedInputTextElement.php:141ReplyAcknowledged -
Andreas Kienast uploaded patch set 7
CR +1V +103/19/24, 07:15 -
core-ci voted on patch set 7 V +1 03/19/24, 07:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54674
-
Markus Klein voted on patch set 7 CR +1 03/19/24, 09:41
-
Markus Klein commented on patch set 7 03/19/24, 09:47
InputTextElement.php:149Thought: Why do we implode the evalList here only to explode it in JS again? Maybe I'm missing something? -
Andreas Kienast commented on patch set 7 03/19/24, 11:38
InputTextElement.php:149ReplyIt has been like this since the initial introduction in v7. I also thought about changing this, but it's breaking for 3rd party integrations. We could do this with a TCA migration in place, but I'd consider such change not beneficial enough. -
Markus Klein voted on patch set 7 V +1 03/19/24, 14:52
-
Oli Bartsch voted on patch set 7 CR +1 V +1 03/21/24, 13:24
-
Andreas Kienast voted on patch set 7 CR +2 V +2 03/21/24, 14:25
-
Andreas Kienast merged patch set 8 03/21/24, 14:38
form-engine-validation.ts:222