Review main Merged

83086[FEATURE] Introduce tree node status information

Benjamin Kott CR +2 V +2 Normal +235 −12 updated 02/23/24, 16:33

Commit message

We've enhanced the backend tree component by extending tree nodes to
incorporate status information. These details serve to indicate the
status of nodes and provide supplementary information.

For instance, if a page undergoes changes within a workspace, it will
now display an indicator on the respective tree node. Additionally,
the status is appended to the node's title. This enhancement not only
improves visual clarity but also enhances information accessibility.

Each node can accommodate multiple status information, prioritized by
severity and urgency. Critical messages take precedence over other
status notifications.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 16

Review log 1928

Show 23 earlier messages
  1. Benjamin Kott uploaded patch set 1 02/23/24, 10:18

  2. core-ci voted on patch set 1 V -1 02/23/24, 10:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53471

  3. Andreas Kienast commented on patch set 1 02/23/24, 10:33

    tree.ts:1020

    `return nothing;` should also work. This requires to change the return declaration to `TemplateResult | symbol`.
  1. Benjamin Kott uploaded patch set 2 V -1 02/23/24, 10:36

  2. core-ci voted on patch set 2 V -1 02/23/24, 10:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53473

  3. Benjamin Kott uploaded patch set 3 V -1 02/23/24, 11:10

  4. Benjamin Kott commented on patch set 3 02/23/24, 11:11

    tree.ts:1020 Reply

    we always only return template results.
  5. core-ci voted on patch set 3 V -1 02/23/24, 11:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53474

  6. Benjamin Kott uploaded patch set 4 V -1 02/23/24, 12:29

  7. core-ci voted on patch set 4 V -1 02/23/24, 12:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53482

  8. Benjamin Kott uploaded patch set 5 V -1 02/23/24, 12:45

  9. core-ci voted on patch set 5 V -1 02/23/24, 12:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53484

  10. Benjamin Kott uploaded patch set 6 V -1 02/23/24, 13:29

  11. Benjamin Kott uploaded patch set 7 02/23/24, 13:34

  12. core-ci voted on patch set 6 V -1 02/23/24, 13:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53494

  13. core-ci voted on patch set 7 V +1 02/23/24, 13:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53496

  14. Benjamin Franzke commented on patch set 7 CR +1 02/23/24, 14:03

    ❤️

    tree.ts:1020 Reply

    Well, I often use `TemplateResult | typeof nothing` in order to be able to use `return nothing` – but I agree that sucks in lit (never found something more generic in `lit` – todo: upstream feature request...)

    tree.ts:1033

    Minor nitpick: ideally we'd be using `ifDefined` lit-directive here in order to only define this attribute when needed.
  15. Benjamin Franzke voted on patch set 7 V +1 02/23/24, 14:24

  16. Andreas Kienast commented on patch set 7 CR +1 V +1 02/23/24, 14:45

    PageTreeItemsHighlighter.php:66

    nitpick: can be shortened to `$item['statusInformation'] ??= [];`
  17. Benjamin Franzke uploaded patch set 8 CR +1 V +1 02/23/24, 15:25

  18. Benjamin Franzke commented on patch set 8 02/23/24, 15:25

    PageTreeItemsHighlighter.php:66 Reply

    Can actually entirely be dropped. ``` $foo = []; $foo['bar'][] = '1'; ``` …is fine. Fixed.
  19. Andreas Kienast uploaded patch set 9 CR +1 V +1 02/23/24, 15:29

  20. Andreas Kienast voted on patch set 9 CR +1 V +1 02/23/24, 15:30

  21. Benjamin Franzke voted on patch set 9 CR +1 V +1 02/23/24, 15:30

  22. core-ci voted on patch set 8 V +1 02/23/24, 15:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53509

  23. core-ci voted on patch set 9 V +1 02/23/24, 15:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53510

  24. Benjamin Franzke voted on patch set 9 CR +2 V +2 02/23/24, 16:33

  25. Benjamin Franzke merged patch set 10 02/23/24, 16:33