83086[FEATURE] Introduce tree node status information
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 16
- Build/Sources/Sass/component/_tree.scss+7 −0
- Build/Sources/TypeScript/backend/tree/page-tree-element.ts+1 −0
- Build/Sources/TypeScript/backend/tree/tree-node.ts+10 −0
- Build/Sources/TypeScript/backend/tree/tree.ts4+50 −2
- typo3/sysext/backend/Classes/Controller/FileStorage/TreeController.php+1 −0
- typo3/sysext/backend/Classes/Controller/Page/TreeController.php+1 −0
- typo3/sysext/backend/Classes/Controller/FormSelectTreeAjaxController.php+1 −0
- typo3/sysext/backend/Classes/Dto/Tree/Status/StatusInformation.phpnew+39 −0
- typo3/sysext/backend/Classes/Dto/Tree/TreeItem.php+6 −0
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −0
- typo3/sysext/backend/Resources/Public/JavaScript/tree/page-tree-element.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/tree/tree.js+13 −3
- typo3/sysext/core/Documentation/Changelog/13.1/Feature-103186-IntroduceTreeNodeStatusInformation.rstnew+48 −0
- typo3/sysext/workspaces/Classes/EventListener/PageTreeItemsHighlighter.php2+20 −2
- typo3/sysext/workspaces/Resources/Private/Language/locallang.xlf+9 −0
- typo3/sysext/workspaces/Tests/Functional/EventListener/PageTreeItemsHighlighterTest.php+27 −4
Review log 1928
Show 23 earlier messages
-
Benjamin Kott uploaded patch set 1 02/23/24, 10:18
-
core-ci voted on patch set 1 V -1 02/23/24, 10:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53471
-
Andreas Kienast commented on patch set 1 02/23/24, 10:33
-
Benjamin Kott uploaded patch set 2
V -102/23/24, 10:36 -
core-ci voted on patch set 2 V -1 02/23/24, 10:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53473
-
Benjamin Kott uploaded patch set 3
V -102/23/24, 11:10 -
Benjamin Kott commented on patch set 3 02/23/24, 11:11
tree.ts:1020Replywe always only return template results. -
core-ci voted on patch set 3 V -1 02/23/24, 11:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53474
-
Benjamin Kott uploaded patch set 4
V -102/23/24, 12:29 -
core-ci voted on patch set 4 V -1 02/23/24, 12:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53482
-
Benjamin Kott uploaded patch set 5
V -102/23/24, 12:45 -
core-ci voted on patch set 5 V -1 02/23/24, 12:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53484
-
Benjamin Kott uploaded patch set 6
V -102/23/24, 13:29 -
Benjamin Kott uploaded patch set 7 02/23/24, 13:34
-
core-ci voted on patch set 6 V -1 02/23/24, 13:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53494
-
core-ci voted on patch set 7 V +1 02/23/24, 13:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53496
-
Benjamin Franzke commented on patch set 7 CR +1 02/23/24, 14:03
❤️tree.ts:1020ReplyWell, I often use `TemplateResult | typeof nothing` in order to be able to use `return nothing` – but I agree that sucks in lit (never found something more generic in `lit` – todo: upstream feature request...)tree.ts:1033Minor nitpick: ideally we'd be using `ifDefined` lit-directive here in order to only define this attribute when needed. -
Benjamin Franzke voted on patch set 7 V +1 02/23/24, 14:24
-
Andreas Kienast commented on patch set 7 CR +1 V +1 02/23/24, 14:45
PageTreeItemsHighlighter.php:66nitpick: can be shortened to `$item['statusInformation'] ??= [];` -
Benjamin Franzke uploaded patch set 8
CR +1V +102/23/24, 15:25 -
Benjamin Franzke commented on patch set 8 02/23/24, 15:25
PageTreeItemsHighlighter.php:66ReplyCan actually entirely be dropped. ``` $foo = []; $foo['bar'][] = '1'; ``` …is fine. Fixed. -
Andreas Kienast uploaded patch set 9
CR +1V +102/23/24, 15:29 -
Andreas Kienast voted on patch set 9 CR +1 V +1 02/23/24, 15:30
-
Benjamin Franzke voted on patch set 9 CR +1 V +1 02/23/24, 15:30
-
core-ci voted on patch set 8 V +1 02/23/24, 15:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53509
-
core-ci voted on patch set 9 V +1 02/23/24, 15:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53510
-
Benjamin Franzke voted on patch set 9 CR +2 V +2 02/23/24, 16:33
-
Benjamin Franzke merged patch set 10 02/23/24, 16:33
tree.ts:1020