Review 12.4 Merged

83089[BUGFIX] Do not race tree node loading

Andreas Kienast CR +2 V +2 Easy +9 −13 updated 03/04/24, 07:54

Commit message

When (de-)mounting pages in the page tree, always two requests are sent
to the server that fetch the tree data:

* when the `mountPointPath` path property is changed as it's a state
  property
* explicitly after changing said property

Especially when de-mounting a page, this tends to race conditions, as
the mount state is additionally stored in the backend user's UC that
needs to get unset as well.

This bugfix now changes the handling when the state property, that
triggers a re-rendering of the tree component, is updated. The
de-mounting process now unsets the backend user's UC first and then
changes the property to make sure that

1. the state is updated once the configuration is flushed
2. the tree nodes are fetched only once

In the mounting process, the UC is correctly updated first. However, the
state was updated and then the nodes were reloaded explicitly. The
latter is not required at all.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • core-ci +1 CI

Issues 1

Files 4

Review log 914

  1. Andreas Kienast uploaded patch set 1 02/23/24, 12:47

  2. Andreas Kienast uploaded patch set 2 02/23/24, 12:48

  3. Andreas Kienast commented on patch set 2 02/23/24, 12:49

    Does not affect 11.5, this bug came when the trees were migrated to Lit.
  4. Andreas Kienast updated the commit message in patch set 3 02/23/24, 12:51

  5. core-ci voted on patch set 1 V +1 02/23/24, 12:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53486

  6. core-ci voted on patch set 2 V +1 02/23/24, 12:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53487

  7. core-ci voted on patch set 3 V +1 02/23/24, 12:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53488

  8. Andreas Kienast commented on patch set 3 02/23/24, 13:13

    Reply

    Done
  9. Andreas Kienast updated the commit message in patch set 4 V +1 02/26/24, 07:24

  10. core-ci voted on patch set 4 V +1 02/26/24, 07:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53566

  11. Andreas Kienast updated the commit message in patch set 5 V +1 02/29/24, 08:49

  12. core-ci voted on patch set 5 V +1 02/29/24, 08:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53704

  13. Andreas Kienast voted on patch set 5 CR +2 V +2 03/04/24, 07:54

  14. Andreas Kienast merged patch set 6 03/04/24, 07:54