Review main Merged

83122[TASK] Raise to phpstan/phpstan-phpunit:^1.3.16

Oliver Klee CR +2 V +2 Easy +2 −2 updated 02/24/24, 12:46

Commit message

Due to a typo, #103193 downgraded the minimum required
phpstan/phpstan-phpunit version.

Executed command:

    composer require --dev \
      phpstan/phpstan-phpunit:^1.3.16

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 2

Files 2

Review log 69

  1. Oliver Klee uploaded patch set 1 02/24/24, 12:27

  2. Stefan Bürk updated the commit message in patch set 2 02/24/24, 12:30

  3. Stefan Bürk voted on patch set 2 CR +1 V +1 02/24/24, 12:30

  4. core-ci voted on patch set 1 V +1 02/24/24, 12:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53533

  5. Stefan Bürk updated the commit message in patch set 3 CR +1 V +1 02/24/24, 12:33

  6. core-ci voted on patch set 2 V +1 02/24/24, 12:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53534

  7. core-ci voted on patch set 3 V +1 02/24/24, 12:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53535

  8. Stefan Bürk commented on patch set 3 CR +2 V +2 02/24/24, 12:41

    Note: Merging as de-facto no-brainer and followup.
  9. Stefan Bürk merged patch set 4 02/24/24, 12:46