Review main Merged

83124[TASK] Use TypoScript static file dependency chain in EXT:styleguide

Benjamin Franzke CR +2 V +2 Easy +6 −10 updated 03/08/24, 18:16

Commit message

Load TypoScript dependencies via include_static_file.txt which
is the defined pattern for loading dependencies of a static template,
ensuring that both constants and typoscript setup of dependencies are
loaded, without having to load all required dependencies both in
constants.typoscript and setup.typoscript.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 813

  1. Benjamin Franzke uploaded patch set 1 02/24/24, 12:43

  2. Benjamin Franzke uploaded patch set 2 02/24/24, 12:45

  3. core-ci voted on patch set 1 V +1 02/24/24, 12:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53538

  4. core-ci voted on patch set 2 V +1 02/24/24, 13:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53539

  5. Benjamin Franzke uploaded patch set 3 V +1 02/24/24, 14:45

  6. core-ci voted on patch set 3 V +1 02/24/24, 14:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53544

  7. Benjamin Franzke rebased onto patch set 4 V +1 02/24/24, 14:52

  8. core-ci voted on patch set 4 V +1 02/24/24, 14:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53546

  9. Benjamin Franzke uploaded patch set 5 V +1 03/04/24, 22:48

  10. core-ci voted on patch set 5 V +1 03/04/24, 22:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53911

  11. Benni Mack voted on patch set 5 CR +1 V +1 03/08/24, 16:10

  12. Stefan Bürk voted on patch set 5 CR +2 V +2 03/08/24, 18:16

  13. Stefan Bürk merged patch set 6 03/08/24, 18:16