Review main Merged

83127[BUGFIX] Indicate loading process when requesting context menu

Andreas Kienast CR +2 V +2 Normal +62 −46 updated 03/04/24, 10:30

Commit message

This commit changes the rendering behavior of context menus. Previously,
the context menu became visible once the server requests were handled
successfully. This is an issue in scenarios where either the server is
under load and may need some time to send a response, or the network
connectivity of the backend user is not optimal.

Now, when requesting a context menu, it's container is shown before any
data is received and a spinner is rendered.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Garvin Hicking +1
    • Markus Klein +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Garvin Hicking +1
    • Markus Klein +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1418

  1. Andreas Kienast uploaded patch set 1 02/26/24, 08:10

  2. Andreas Kienast updated the commit message in patch set 2 02/26/24, 08:11

  3. core-ci voted on patch set 1 V -1 02/26/24, 08:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53567

  4. core-ci voted on patch set 2 V -1 02/26/24, 08:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53568

  5. Andreas Kienast uploaded patch set 3 V -1 02/26/24, 10:45

  6. Andreas Kienast commented on patch set 3 V -1 02/26/24, 10:46

    positioning is off in filelist tile view
  7. core-ci voted on patch set 3 V +1 02/26/24, 10:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53594

  8. Andreas Kienast commented on patch set 3 V 0 02/26/24, 11:04

    The positioning issue in the file list is a bug within the context menu component. This also currently happens on a clean HEAD when creating the context menu the first time. It now happens all the time as file-list.ts has to stop the event propagation of `contextmenu` to the content menu component to avoid side-effects due to the fact the component constantly tries to hide itself. To solve this, the component needs a major refactoring.
  9. Garvin Hicking commented on patch set 3 CR +1 V +1 03/01/24, 07:47

    I've tested this with Chrome and Firefox (OSX) and enabled network+CPU throttling to ensure I can see the spinner. I saw the spinner.🫡
  10. Markus Klein voted on patch set 3 CR +1 V +1 03/02/24, 11:19

  11. Andreas Kienast commented on patch set 3 CR -2 03/04/24, 07:46

  12. Andreas Kienast uploaded patch set 4 CR +1 V +1 03/04/24, 10:02

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  13. Andreas Kienast commented on patch set 3 CR 0 03/04/24, 10:02

    Copied votes on follow-up patch sets have been updated: * Copied Code-Review vote has been removed from patch set 4 (was Code-Review-2) since the new Code-Review=0 vote is not copyable (copy condition: "changekind:NO_CHANGE OR is:MIN").
  14. core-ci voted on patch set 4 V +1 03/04/24, 10:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53820

  15. Garvin Hicking voted on patch set 4 CR +1 V +1 03/04/24, 10:28

  16. Markus Klein voted on patch set 4 CR +1 V +1 03/04/24, 10:28

  17. Andreas Kienast voted on patch set 4 CR +2 V +2 03/04/24, 10:30

  18. Andreas Kienast merged patch set 5 03/04/24, 10:30