83127[BUGFIX] Indicate loading process when requesting context menu
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Garvin Hicking +1
- Markus Klein +1
-
Verified V +2 Done
- Andreas Kienast +2
- Garvin Hicking +1
- Markus Klein +1
- core-ci +1 CI
Issues 1
Files 4
Review log 1418
-
Andreas Kienast uploaded patch set 1 02/26/24, 08:10
-
Andreas Kienast updated the commit message in patch set 2 02/26/24, 08:11
-
core-ci voted on patch set 1 V -1 02/26/24, 08:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53567
-
core-ci voted on patch set 2 V -1 02/26/24, 08:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53568
-
Andreas Kienast uploaded patch set 3
V -102/26/24, 10:45 -
Andreas Kienast commented on patch set 3 V -1 02/26/24, 10:46
positioning is off in filelist tile view -
core-ci voted on patch set 3 V +1 02/26/24, 10:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53594
-
Andreas Kienast commented on patch set 3 V 0 02/26/24, 11:04
The positioning issue in the file list is a bug within the context menu component. This also currently happens on a clean HEAD when creating the context menu the first time. It now happens all the time as file-list.ts has to stop the event propagation of `contextmenu` to the content menu component to avoid side-effects due to the fact the component constantly tries to hide itself. To solve this, the component needs a major refactoring. -
Garvin Hicking commented on patch set 3 CR +1 V +1 03/01/24, 07:47
I've tested this with Chrome and Firefox (OSX) and enabled network+CPU throttling to ensure I can see the spinner. I saw the spinner.🫡 -
Markus Klein voted on patch set 3 CR +1 V +1 03/02/24, 11:19
-
Andreas Kienast commented on patch set 3 CR -2 03/04/24, 07:46
-
Andreas Kienast uploaded patch set 4
CR +1V +103/04/24, 10:02Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
Andreas Kienast commented on patch set 3 CR 0 03/04/24, 10:02
Copied votes on follow-up patch sets have been updated: * Copied Code-Review vote has been removed from patch set 4 (was Code-Review-2) since the new Code-Review=0 vote is not copyable (copy condition: "changekind:NO_CHANGE OR is:MIN"). -
core-ci voted on patch set 4 V +1 03/04/24, 10:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53820
-
Garvin Hicking voted on patch set 4 CR +1 V +1 03/04/24, 10:28
-
Markus Klein voted on patch set 4 CR +1 V +1 03/04/24, 10:28
-
Andreas Kienast voted on patch set 4 CR +2 V +2 03/04/24, 10:30
-
Andreas Kienast merged patch set 5 03/04/24, 10:30