Review main Merged

83128[BUGFIX] Streamline `typo3-spinner-icon` element with SVG asset

Andreas Kienast CR +2 V +2 Normal +25 −42 updated 02/29/24, 14:16

Commit message

The Lit element `typo3-backend-spinner` uses a hard-coded SVG string,
which has to be the same as the `spinner-circle` asset file.

However, the SVG string was outdated as it neither respected the
`currentColor`, nor respected the configured icon size. Both issues are
fixed in this commit. Since `currentColor` is now taken into account,
the variant styling has been removed.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Garvin Hicking +1
    • Jörg Bösche +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Garvin Hicking +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 16

Review log 1316

  1. Andreas Kienast uploaded patch set 1 02/26/24, 08:15

  2. core-ci voted on patch set 1 V +1 02/26/24, 08:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53569

  3. Andreas Kienast uploaded patch set 2 V +1 02/26/24, 08:27

  4. core-ci voted on patch set 2 V +1 02/26/24, 08:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53570

  5. Andreas Kienast commented on patch set 2 CR -1 02/26/24, 08:44

    on it
  6. Andreas Kienast uploaded patch set 3 CR -1 V +1 02/26/24, 08:59

  7. core-ci voted on patch set 3 V +1 02/26/24, 09:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53588

  8. Benni Mack commented on patch set 3 02/26/24, 15:36

    spinner-element.ts:19

    recommend to not backport this to v12 when killing options
  9. Andreas Kienast commented on patch set 3 02/26/24, 15:41

    spinner-element.ts:19 Reply

    The options are already dead in v12.
  10. Andreas Kienast commented on patch set 3 02/26/24, 15:42

    spinner-element.ts:19 Reply

    (in terms of "unusable")
  11. Benni Mack commented on patch set 3 CR +1 V +1 02/26/24, 16:26

    spinner-element.ts:19 Reply

    Done
  12. Jörg Bösche voted on patch set 3 CR +1 02/27/24, 08:10

  13. Benjamin Franzke voted on patch set 3 CR +1 V +1 02/29/24, 12:48

  14. Andreas Kienast voted on patch set 3 CR +2 V +2 02/29/24, 12:49

  15. Andreas Kienast merged patch set 4 02/29/24, 12:58

  16. Garvin Hicking commented on patch set 4 CR +1 V +1 02/29/24, 14:16

    post-merge +1, works for me :D