83128[BUGFIX] Streamline `typo3-spinner-icon` element with SVG asset
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
- Garvin Hicking +1
- Jörg Bösche +1
- Benni Mack +1
-
Verified V +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
- Garvin Hicking +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 16
- Build/Sources/TypeScript/backend/element/spinner-element.ts4+6 −19
- Build/Sources/TypeScript/backend/pagetsconfig/pagetsconfig-includes.ts+1 −1
- Build/Sources/TypeScript/backend/clipboard-panel.ts+1 −1
- Build/Sources/TypeScript/backend/image-manipulation.ts+1 −1
- Build/Sources/TypeScript/backend/modal.ts+1 −1
- Build/Sources/TypeScript/install/router.ts+1 −1
- Build/Sources/TypeScript/tstemplate/template-analyzer.ts+1 −1
- Build/Sources/TypeScript/workspaces/workspaces.ts+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/element/spinner-element.js+5 −9
- typo3/sysext/backend/Resources/Public/JavaScript/pagetsconfig/pagetsconfig-includes.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/clipboard-panel.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/image-manipulation.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/modal.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/router.js+1 −1
- typo3/sysext/tstemplate/Resources/Public/JavaScript/template-analyzer.js+1 −1
- typo3/sysext/workspaces/Resources/Public/JavaScript/workspaces.js+1 −1
Review log 1316
-
Andreas Kienast uploaded patch set 1 02/26/24, 08:15
-
core-ci voted on patch set 1 V +1 02/26/24, 08:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53569
-
Andreas Kienast uploaded patch set 2
V +102/26/24, 08:27 -
core-ci voted on patch set 2 V +1 02/26/24, 08:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53570
-
Andreas Kienast commented on patch set 2 CR -1 02/26/24, 08:44
on it -
Andreas Kienast uploaded patch set 3
CR -1V +102/26/24, 08:59 -
core-ci voted on patch set 3 V +1 02/26/24, 09:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53588
-
Benni Mack commented on patch set 3 02/26/24, 15:36
spinner-element.ts:19recommend to not backport this to v12 when killing options -
Andreas Kienast commented on patch set 3 02/26/24, 15:41
spinner-element.ts:19ReplyThe options are already dead in v12. -
Andreas Kienast commented on patch set 3 02/26/24, 15:42
spinner-element.ts:19Reply(in terms of "unusable") -
Benni Mack commented on patch set 3 CR +1 V +1 02/26/24, 16:26
spinner-element.ts:19ReplyDone -
Jörg Bösche voted on patch set 3 CR +1 02/27/24, 08:10
-
Benjamin Franzke voted on patch set 3 CR +1 V +1 02/29/24, 12:48
-
Andreas Kienast voted on patch set 3 CR +2 V +2 02/29/24, 12:49
-
Andreas Kienast merged patch set 4 02/29/24, 12:58
-
Garvin Hicking commented on patch set 4 CR +1 V +1 02/29/24, 14:16
post-merge +1, works for me :D