Review main Merged

83132[BUGFIX] Cast DOM attribute values to string

Helmut Hummel CR +2 V +2 Easy +1 −1 updated 03/06/24, 21:12

Commit message

To avoid passing integer values, all values are now
cast to string.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1013

  1. Helmut Hummel uploaded patch set 1 02/26/24, 11:10

  2. Helmut Hummel updated the commit message in patch set 2 02/26/24, 11:14

  3. Benni Mack commented on patch set 2 02/26/24, 11:15

    I think this is related to PHP 8? So we should also backport this to v11.5
  4. core-ci voted on patch set 1 V +1 02/26/24, 11:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53596

  5. core-ci voted on patch set 2 V +1 02/26/24, 11:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53597

  6. Oliver Klee voted on patch set 2 CR +1 02/26/24, 13:36

  7. Christian Kuhn uploaded patch set 3 CR +1 V +1 03/06/24, 20:47

  8. Christian Kuhn voted on patch set 3 CR +1 V +1 03/06/24, 20:47

  9. core-ci voted on patch set 3 V +1 03/06/24, 20:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54074

  10. Stefan Bürk voted on patch set 3 CR +1 V +1 03/06/24, 21:06

  11. Oliver Klee voted on patch set 3 CR +1 V +1 03/06/24, 21:08

  12. Christian Kuhn voted on patch set 3 CR +2 V +2 03/06/24, 21:11

  13. Christian Kuhn merged patch set 4 03/06/24, 21:12