Review main Merged

83135[BUGFIX] Restore FileInterface::setContents() TODO comments

Mathias Brodala CR +2 V +2 Easy +6 −2 updated 02/26/24, 12:54

Commit message

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Garvin Hicking +1
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Garvin Hicking +1
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1012

  1. Mathias Brodala uploaded patch set 1 02/26/24, 12:01

  2. Garvin Hicking voted on patch set 1 CR +1 V +1 02/26/24, 12:10

  3. core-ci voted on patch set 1 V +1 02/26/24, 12:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53608

  4. Christian Kuhn commented on patch set 1 02/26/24, 12:15

    FileInterface.php:100

    please indent: this makes phpstorm understand this line is part of the above todo.
  5. Mathias Brodala uploaded patch set 2 CR +1 V +1 02/26/24, 12:19

  6. Mathias Brodala commented on patch set 2 02/26/24, 12:19

    FileInterface.php:100 Reply

    Done
  7. core-ci voted on patch set 2 V +1 02/26/24, 12:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53609

  8. Christian Kuhn voted on patch set 2 CR +1 V +1 02/26/24, 12:28

  9. Garvin Hicking voted on patch set 2 CR +1 V +1 02/26/24, 12:28

  10. Andreas Kienast voted on patch set 2 CR +2 V +2 02/26/24, 12:37

  11. Stefan Bürk voted on patch set 2 CR +1 V +1 02/26/24, 12:54

  12. Andreas Kienast merged patch set 3 02/26/24, 12:54