Review main Merged

83140[DOCS] Add hint to EXT:redirects regarding LinkHandler

Peter Kraume CR +2 V +2 Easy +13 −1 updated 06/21/24, 12:22

Commit message

Using constants in the LinkHandler TSConfig does not work in the
redirects module.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jörg Bösche +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 89

  1. Peter Kraume uploaded patch set 1 02/26/24, 14:41

  2. core-ci voted on patch set 1 V +1 02/26/24, 14:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53621

  3. Jörg Bösche voted on patch set 1 CR +1 02/27/24, 08:11

  4. Stefan Bürk commented on patch set 1 02/27/24, 20:35

    Index.rst:12

    Not tested or looked into the code - but is it not also required that the LinkHandler PageTS configuration is globally loaded, and not for some page downwards ?
  5. Josef Glatz commented on patch set 1 02/28/24, 04:08

    does it really resolves the issue? I would rather add it as Related patch. not using site settings aka constants feels like a structural problem in the redirects module which should be fixed on another level?
  6. Stefan Bürk commented on patch set 1 03/14/24, 14:36

    Reply

    The issue/patch is about documenting this behaviour. You are right - but that is not easy doable and needs a lot of pre-work and several places which gets even more delayed to "not-being breaking".
  7. Benni Mack voted on patch set 1 CR +1 V +1 06/21/24, 09:52

  8. Christian Kuhn commented on patch set 1 CR +2 V +2 06/21/24, 12:00

    Index.rst:12 Reply

    unsure. i guess we should have a look at the overall situation anyways with another patch. i think that docs change is fine for now.
  9. Christian Kuhn merged patch set 2 06/21/24, 12:22