Review main Merged

83145[TASK] Avoid phpunit onConsecutiveCalls()

Christian Kuhn CR +2 V +2 Easy +8 −22 updated 02/27/24, 12:26

Commit message

phpunit 11 deprecation:
Use `$double->willReturn()` instead of
`$double->will($this->onConsecutiveCalls())`.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 69

  1. Christian Kuhn uploaded patch set 1 02/27/24, 09:17

  2. core-ci voted on patch set 1 V -1 02/27/24, 09:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53632

  3. Christian Kuhn uploaded patch set 2 V -1 02/27/24, 11:38

  4. Christian Kuhn updated the commit message in patch set 3 02/27/24, 11:42

  5. core-ci voted on patch set 2 V +1 02/27/24, 11:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53634

  6. core-ci voted on patch set 3 V +1 02/27/24, 11:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53636

  7. Stefan Bürk voted on patch set 3 CR +1 V +1 02/27/24, 12:12

  8. Anja Leichsenring voted on patch set 3 CR +2 V +2 02/27/24, 12:26

  9. Anja Leichsenring merged patch set 4 02/27/24, 12:26