Review main Merged

83147[TASK] Modernize cache framework unit tests

Christian Kuhn CR +2 V +2 Hard +435 −386 updated 02/27/24, 15:38

Commit message

* Less mocking
* Don't test AbstractFrontend but implementations
* Turn test-internal loops into data providers
* General cleanup
* Avoid phpunit 11 deprecations

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Anja Leichsenring +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 15

Review log 78

  1. Christian Kuhn uploaded patch set 1 02/27/24, 14:56

  2. core-ci voted on patch set 1 V +1 02/27/24, 15:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53643

  3. Oliver Klee voted on patch set 1 V +1 02/27/24, 15:22

  4. Oliver Klee voted on patch set 1 CR +1 02/27/24, 15:24

  5. Anja Leichsenring voted on patch set 1 CR +1 V +1 02/27/24, 15:29

  6. Stefan Bürk voted on patch set 1 CR +1 V +1 02/27/24, 15:33

  7. Christian Kuhn voted on patch set 1 CR +2 V +2 02/27/24, 15:38

  8. Christian Kuhn merged patch set 2 02/27/24, 15:38