Review main Merged

83148[TASK] Avoid phpunit static TestCase->never() and once()

Christian Kuhn CR +2 V +2 Normal +32 −31 updated 02/27/24, 15:38

Commit message

The methods are no longer static in phpunit 11 and
should not be used in data providers. We split a data
provider to deal with this.

The final switch to not call these statically will
be done when phpunit is raised, since it otherwise
collides with cgl checks and current phpunit 10.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Christian Kuhn uploaded patch set 1 02/27/24, 15:17

  2. Oliver Klee voted on patch set 1 CR +1 02/27/24, 15:22

  3. core-ci voted on patch set 1 V +1 02/27/24, 15:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53644

  4. Oliver Klee voted on patch set 1 V +1 02/27/24, 15:24

  5. Anja Leichsenring voted on patch set 1 CR +1 V +1 02/27/24, 15:31

  6. Christian Kuhn voted on patch set 1 CR +2 V +2 02/27/24, 15:38

  7. Christian Kuhn merged patch set 2 02/27/24, 15:38