Review main Merged

83150[TASK] Avoid phpunit addMethods()

Christian Kuhn CR +2 V +2 Hard +181 −357 updated 02/27/24, 17:40

Commit message

phpunit 11 deprecates addMethods() on mocks.
There are various solutions:

* Use onlyMethods([]) instead of
  addMethods(['dummy']) to "mock nothing"
* Remove a couple of calls that were bogus
  in the first place
* Turn calls into mocks of interfaces
* Turn calls into mocks of fixture classes
* Instantiate a subject with new()

Also have the one or the other minor cleanup as drive-by.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 24

Show 4 more files