Review main Work in progress Orphaned

83151[TASK] Flush page cache on updating records in "Insert records"

Christoph Lehmann CR +1 V 0 Easy +5 −0 updated 02/19/25, 16:33

Commit message

This adds page cache tags for tt_content records that are referenced in the "Insert records" content element. When changing these records, the page cache of the referencing pages is now cleared automatically.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 1
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/51/83151/1 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/51/83151/1 && git cherry-pick FETCH_HEAD

Review

  • Code review CR +1 Needs a vote
    • Dan Kleine - geb. Untenzu +1
    • Jörg Bösche +1
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Issues 1

Files 1

Review log 78

  1. Christoph Lehmann uploaded patch set 1 02/27/24, 17:58

  2. core-ci voted on patch set 1 V +1 02/27/24, 18:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53656

  3. Jörg Bösche voted on patch set 1 CR +1 03/25/24, 11:58

  4. Stefan Bürk commented on patch set 1 03/27/24, 16:23

    Shortcut.typoscript:16

    Cannot test at the moment, but from reading: https://docs.typo3.org/m/typo3/reference-typoscript/main/en-us/ContentObjects/Records/Index.html#conf it says: > If this is not defined, the rendering of the records is done with the top-level object [table name] - just like when .renderObj is not set for the cObject CONTENT! So would this not make the `tt_content.` usweles for content elements than ? (TBJ a test would show this but cannot do that right now) - and not looked into the RecordsContentObject code what hapens here.
  5. Christoph Lehmann commented on patch set 1 04/16/24, 11:03

    Shortcut.typoscript:16 Reply

    Rendering is fine. The default CONTENT is used, because i do not write conf.tt_content = TEXT Will look for a test and clarify this in the docs.
  6. Dan Kleine - geb. Untenzu voted on patch set 1 CR +1 06/21/24, 07:44

  7. Benni Mack commented on patch set 1 01/08/25, 16:36

    Shortcut.typoscript:16 Reply Unresolved

    ping :) let's get this done.
  8. Benni Mack marked it work in progress 02/19/25, 16:33