Review main Merged

83157[TASK] Avoid phpunit setLocale()

Christian Kuhn CR +2 V +2 Normal +0 −88 updated 02/28/24, 10:54

Commit message

Deprecated in phpunit 11. Used once.
We remove that test entirely since it
is a direct call to GU::formatSize()
which has its own tests already.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Oliver Klee +1

Issues 1

Files 1

Review log 1114

  1. Christian Kuhn uploaded patch set 1 02/28/24, 10:21

  2. Christian Kuhn uploaded patch set 2 02/28/24, 10:25

  3. core-ci voted on patch set 1 V -1 02/28/24, 10:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53679

  4. Oliver Klee commented on patch set 2 CR -1 02/28/24, 10:30

    Environment restoring needs to happen in `tearDown()` as any exception will exit a test method, and hence environment-restoring code in a test method is not ensured to get executed under all circumstances, which will result in a polluted environment for the subsequent tests.
  5. core-ci voted on patch set 2 V +1 02/28/24, 10:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53680

  6. Anja Leichsenring commented on patch set 2 02/28/24, 10:34

    Reply

    the assertion happens after the restore, so we should be save.
  7. Christian Kuhn commented on patch set 2 02/28/24, 10:35

    Reply

    exactly. that's why i turned this around.
  8. Christian Kuhn uploaded patch set 3 CR -1 V +1 02/28/24, 10:49

  9. Anja Leichsenring voted on patch set 3 CR +1 V +1 02/28/24, 10:49

  10. Anja Leichsenring commented on patch set 3 02/28/24, 10:50

    Reply

    problem solved by throwing it away :) I like.
  11. Oliver Klee voted on patch set 3 CR +1 V +1 02/28/24, 10:50

  12. Anja Leichsenring voted on patch set 3 CR +2 V +2 02/28/24, 10:51

  13. Anja Leichsenring merged patch set 4 02/28/24, 10:51

  14. core-ci voted on patch set 3 V +1 02/28/24, 10:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53681