83157[TASK] Avoid phpunit setLocale()
Commit message
Review
-
Code review CR +2 Done
- Anja Leichsenring +2
- Oliver Klee +1
-
Verified V +2 Done
- Anja Leichsenring +2
- Oliver Klee +1
Issues 1
Files 1
Review log 1114
-
Christian Kuhn uploaded patch set 1 02/28/24, 10:21
-
Christian Kuhn uploaded patch set 2 02/28/24, 10:25
-
core-ci voted on patch set 1 V -1 02/28/24, 10:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53679
-
Oliver Klee commented on patch set 2 CR -1 02/28/24, 10:30
Environment restoring needs to happen in `tearDown()` as any exception will exit a test method, and hence environment-restoring code in a test method is not ensured to get executed under all circumstances, which will result in a polluted environment for the subsequent tests. -
core-ci voted on patch set 2 V +1 02/28/24, 10:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53680
-
Anja Leichsenring commented on patch set 2 02/28/24, 10:34
Reply
the assertion happens after the restore, so we should be save. -
Christian Kuhn commented on patch set 2 02/28/24, 10:35
Reply
exactly. that's why i turned this around. -
Christian Kuhn uploaded patch set 3
CR -1V +102/28/24, 10:49 -
Anja Leichsenring voted on patch set 3 CR +1 V +1 02/28/24, 10:49
-
Anja Leichsenring commented on patch set 3 02/28/24, 10:50
Reply
problem solved by throwing it away :) I like. -
Oliver Klee voted on patch set 3 CR +1 V +1 02/28/24, 10:50
-
Anja Leichsenring voted on patch set 3 CR +2 V +2 02/28/24, 10:51
-
Anja Leichsenring merged patch set 4 02/28/24, 10:51
-
core-ci voted on patch set 3 V +1 02/28/24, 10:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53681