Review main Merged

83158[BUGFIX] TreeNode creation and cleanup

Benjamin Kott CR +2 V +2 Easy +14 −6 updated 02/28/24, 19:39

Commit message

Correctly extend and show the children of the
parentnode when a node is added. Clean up
the parent node status when a node is removed
and no longer contains child nodes.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Benjamin Kott uploaded patch set 1 02/28/24, 12:49

  2. Benjamin Kott commented on patch set 1 02/28/24, 12:53

    New node on node without children: - Create a new node by dragging into a node that does not has children. - Press Escape to cancel the node generation - See that the node still shows an arrow that indicates it has children Validate: - Child indicator removed correctly New node after node without children: - Create a new node by dragging after an existing node, without children - See that the node before the element now contains an arrow that indicates that it contains children Validate: - Child indicator is added to the correct parent node
  3. core-ci voted on patch set 1 V +1 02/28/24, 12:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53682

  4. Oli Bartsch voted on patch set 1 CR +1 V +1 02/28/24, 14:12

  5. Benni Mack voted on patch set 1 CR +2 V +2 02/28/24, 19:39

  6. Benni Mack merged patch set 2 02/28/24, 19:39