83162[TASK] Show backend user groups in backend users list view
Commit message
Review
-
Code review CR +2 Done
- Benjamin Kott +2
- Oli Bartsch +1
- Frank Nägler +1
-
Verified V +2 Done
- Benjamin Kott +2
- Oli Bartsch +1
- Frank Nägler +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/beuser/Resources/Private/Partials/BackendUser/PaginatedList.html3+8 −2
- typo3/sysext/beuser/Resources/Private/Partials/BackendUserGroup/PaginatedList.html+3 −6
- typo3/sysext/beuser/Resources/Private/Templates/BackendUser/Compare.html+1 −1
- typo3/sysext/beuser/Resources/Private/Templates/BackendUser/List.html+2 −2
- typo3/sysext/core/Tests/Acceptance/Application/BackendUser/CompareUserCest.php+2 −2
Review log 89
-
Benjamin Kott uploaded patch set 1 02/29/24, 10:52
-
core-ci voted on patch set 1 V +1 02/29/24, 10:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53713
-
Oli Bartsch commented on patch set 1 02/29/24, 21:00
-
Benjamin Kott commented on patch set 1 03/01/24, 09:12
PaginatedList.html:49ReplyI also stumbled over this. I think we should not handle this specific case - as it reflects the active state. But I find it very confusing because I double-checked the selection and it took a while to figure out that one of the selected groups was disabled - this needs to be visible in the selection (Formengine). -
Oli Bartsch commented on patch set 1 CR +1 V +1 03/01/24, 11:04
PaginatedList.html:49ReplyAcknowledged -
Frank Nägler voted on patch set 1 CR +1 03/01/24, 11:09
-
Frank Nägler voted on patch set 1 V +1 03/01/24, 11:11
-
Benjamin Kott voted on patch set 1 CR +2 V +2 03/01/24, 11:33
-
Benjamin Kott merged patch set 2 03/01/24, 11:33
PaginatedList.html:49