Review main Merged

83162[TASK] Show backend user groups in backend users list view

Benjamin Kott CR +2 V +2 Easy +16 −13 updated 03/01/24, 11:33

Commit message

If you are managing backend users, it is now also possible to view
the assigned groups directly. The hardcoded edit labels are now
also replaced with the respecting translatable variants.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Oli Bartsch +1
    • Frank Nägler +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Oli Bartsch +1
    • Frank Nägler +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 89

  1. Benjamin Kott uploaded patch set 1 02/29/24, 10:52

  2. core-ci voted on patch set 1 V +1 02/29/24, 10:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53713

  3. Oli Bartsch commented on patch set 1 02/29/24, 21:00

    PaginatedList.html:49

    In case the user contains disabled user groups, those are not displayed. Should we handle this?
  4. Benjamin Kott commented on patch set 1 03/01/24, 09:12

    PaginatedList.html:49 Reply

    I also stumbled over this. I think we should not handle this specific case - as it reflects the active state. But I find it very confusing because I double-checked the selection and it took a while to figure out that one of the selected groups was disabled - this needs to be visible in the selection (Formengine).
  5. Oli Bartsch commented on patch set 1 CR +1 V +1 03/01/24, 11:04

    PaginatedList.html:49 Reply

    Acknowledged
  6. Frank Nägler voted on patch set 1 CR +1 03/01/24, 11:09

  7. Frank Nägler voted on patch set 1 V +1 03/01/24, 11:11

  8. Benjamin Kott voted on patch set 1 CR +2 V +2 03/01/24, 11:33

  9. Benjamin Kott merged patch set 2 03/01/24, 11:33