Review 12.4 Merged

83164[BUGFIX] Streamline `typo3-spinner-icon` element with SVG asset

Andreas Kienast CR +2 V +2 Normal +23 −40 updated 02/29/24, 12:58

Commit message

The Lit element `typo3-backend-spinner` uses a hard-coded SVG string,
which has to be the same as the `spinner-circle` asset file.

However, the SVG string was outdated as it neither respected the
`currentColor`, nor respected the configured icon size. Both issues are
fixed in this commit. Since `currentColor` is now taken into account,
the variant styling has been removed.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • core-ci +1 CI

Issues 1

Files 14

Review log 34

  1. Andreas Kienast uploaded patch set 1 02/29/24, 12:52

  2. core-ci voted on patch set 1 V +1 02/29/24, 12:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53722

  3. Andreas Kienast voted on patch set 1 CR +2 V +2 02/29/24, 12:58

  4. Andreas Kienast merged patch set 2 02/29/24, 12:58