Review main Merged

83167[BUGFIX] Allow search for newly created versioned records in page tree

Benni Mack CR +2 V +2 Easy +8 −0 updated 05/14/24, 11:55

Commit message

This change allows for search for UIDs
of versioned records in the page tree,
which have been created within the workspace.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 78

  1. Benni Mack uploaded patch set 1 03/01/24, 07:38

  2. core-ci voted on patch set 1 V +1 03/01/24, 07:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53741

  3. Oli Bartsch voted on patch set 1 CR +1 V +1 03/01/24, 14:14

  4. Lina Wolf commented on patch set 1 03/04/24, 09:43

    My issue which is maybe not related after all is not resolved by this patch
  5. Lina Wolf commented on patch set 1 03/04/24, 09:48

    Reply

    The following would solve it: ``` Index: Classes/Hooks/TreelistCacheUpdateHooks.php IDEA additional info: Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP <+>UTF-8 =================================================================== diff --git a/Classes/Hooks/TreelistCacheUpdateHooks.php b/Classes/Hooks/TreelistCacheUpdateHooks.php --- a/Classes/Hooks/TreelistCacheUpdateHooks.php +++ b/Classes/Hooks/TreelistCacheUpdateHooks.php (date 1709543377998) @@ -78,7 +78,7 @@ if ($status === 'new') { // Detect new pages // Resolve the uid - $affectedPageUid = $dataHandler->substNEWwithIDs[$recordId]; + $affectedPageUid = $dataHandler->substNEWwithIDs[$recordId] ?? 0; $affectedPagePid = $updatedFields['pid']; } elseif ($status === 'update') { // Detect updated pages ```
  6. Christian Kuhn voted on patch set 1 CR +1 V +1 03/05/24, 18:00

  7. Benni Mack voted on patch set 1 CR +2 V +2 05/14/24, 11:54

  8. Benni Mack merged patch set 2 05/14/24, 11:55