Review main Abandoned

83168[BUGFIX] Respect language fallback chain for record overlay

Stephan Salzmann CR 0 V 0 Easy +12 −4 updated 03/28/25, 12:30

Commit message

If you want to get a record overlay for a database object, the language fallback is not taken into account.
This fix works with the first record found in the language fallback.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 57

  1. Stephan Salzmann uploaded patch set 1 03/01/24, 08:50

  2. Benni Mack commented on patch set 1 03/01/24, 08:55

    Hey Stephan, have you tried using PageRepository->getLanguageOverlay()?
  3. Stephan Salzmann commented on patch set 1 03/01/24, 09:24

    Reply

    Hi Benni, yes, this is the way I came from to catch the translation for this record. I noticed this bug during indexing records for Solr with the Solr extension. I have a similiar site configuration mentioned in the forge issue. The sysfolder is translated in different languages (e.g. language uids 0,1,2), the record exists in the languages 0 and 1. The language with uid 2 has a language fallback to 1 in the site configuration. When you index now these records the solr extensions went the complete right way also with PageRepository->getLanguageOverlay() and return $this->getRecordOverlay( $table, $row, $languageAspect ); but in getRecordOverlay you will work with the original record ($row) with language uid 0 in the $languageAspect respictively $sys_language_content in getRecordOverlay() contains only the language uid 2 and falls back to the record with language uid 0 because there is no translation for this record with language uid 2. This is because the fallback languages are not passed on or taken into account at this point.
  4. core-ci voted on patch set 1 V -1 03/01/24, 09:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53743

  5. Benni Mack updated the commit message in patch set 2 V -1 10/18/24, 13:23

  6. core-ci voted on patch set 2 V -1 10/18/24, 18:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67959

  7. Benni Mack abandoned the change 03/28/25, 12:30