Review main Merged

83169[BUGFIX] Respect language fallback chain for record overlay

Stephan Salzmann CR +2 V +2 Normal +33 −33 updated 03/28/25, 16:30

Commit message

If you want to get a record overlay for a database object, the
language fallback is not taken into account.

This fix works with the first record found in the language fallback.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1727

Show 12 earlier messages
  1. Stephan Salzmann uploaded patch set 1 03/01/24, 09:40

  2. core-ci voted on patch set 1 V -1 03/01/24, 09:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53744

  1. Stefan Bürk commented on patch set 1 03/13/24, 11:30

    should be merged with -> https://review.typo3.org/c/Packages/TYPO3.CMS/+/83168/1 guess. Missed to properly amend to the original change and therefore created a new change on top as relation chain.
  2. Benni Mack updated the commit message in patch set 2 V -1 10/18/24, 13:24

  3. core-ci voted on patch set 2 V -1 10/18/24, 15:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67962

  4. Benni Mack commented on patch set 3 V -1 03/28/25, 12:30

    Published edit on patch set 2.
  5. Benni Mack rebased onto patch set 4 03/28/25, 12:31

  6. core-ci voted on patch set 3 V -1 03/28/25, 12:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76588

  7. core-ci voted on patch set 4 V -1 03/28/25, 12:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76589

  8. Benni Mack uploaded patch set 5 V -1 03/28/25, 13:29

  9. Benni Mack commented on patch set 5 03/28/25, 13:30

    Reply

    Done
  10. core-ci voted on patch set 5 V -1 03/28/25, 13:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76593

  11. Garvin Hicking commented on patch set 5 03/28/25, 13:57

    PageRepository.php:747

    $languageAspect->getContentId() ?

    PageRepository.php:765

    $languageField?
  12. Benni Mack uploaded patch set 6 V -1 03/28/25, 14:09

  13. Benni Mack commented on patch set 6 03/28/25, 14:10

    PageRepository.php:747 Reply

    Done

    PageRepository.php:765 Reply

    Done
  14. core-ci voted on patch set 6 V -1 03/28/25, 14:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76596

  15. Benni Mack uploaded patch set 7 V -1 03/28/25, 15:29

  16. Benni Mack uploaded patch set 8 03/28/25, 15:35

  17. core-ci voted on patch set 7 V +1 03/28/25, 15:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76598

  18. core-ci voted on patch set 8 V +1 03/28/25, 15:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76601

  19. Benni Mack uploaded patch set 9 V +1 03/28/25, 15:59

  20. core-ci voted on patch set 9 V -1 03/28/25, 16:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76602

  21. Benni Mack commented on patch set 10 V -1 03/28/25, 16:11

    Published edit on patch set 9.
  22. core-ci voted on patch set 10 V +1 03/28/25, 16:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76603

  23. Garvin Hicking voted on patch set 10 CR +1 V +1 03/28/25, 16:22

  24. Benni Mack voted on patch set 10 CR +2 V +2 03/28/25, 16:22

  25. Benni Mack merged patch set 11 03/28/25, 16:30