83171[DOCS] Switch adminpanel docs to PHP-based rendering
Commit message
Review
-
Code review CR +2 Done
- Lina Wolf +2
- Chris Müller +1
- Benni Mack +1
-
Verified V +2 Done
- Lina Wolf +2
- Chris Müller +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 6
- typo3/sysext/adminpanel/Documentation/Configuration/Index.rst2+10 −7
- typo3/sysext/adminpanel/Documentation/genindex.rstdeleted+0 −7
- typo3/sysext/adminpanel/Documentation/guides.xmlnew+17 −0
- typo3/sysext/adminpanel/Documentation/Includes.rst.txt+1 −34
- typo3/sysext/adminpanel/Documentation/Index.rst+0 −1
- typo3/sysext/adminpanel/Documentation/Settings.cfgdeleted+0 −71
Review log 1315
-
Lina Wolf uploaded patch set 1 03/01/24, 11:30
-
core-ci voted on patch set 1 V +1 03/01/24, 11:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53748
-
Chris Müller commented on patch set 1 CR -1 03/01/24, 11:56
-
Lina Wolf uploaded patch set 2
CR -1V +103/01/24, 11:59 -
Lina Wolf commented on patch set 2 03/01/24, 11:59
Index.rst:40ReplyDone -
Chris Müller voted on patch set 2 CR +1 V +1 03/01/24, 12:03
-
core-ci voted on patch set 2 V +1 03/01/24, 12:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53749
-
Chris Müller commented on patch set 2 03/01/24, 12:14
For those who want to test: 1. Switch to the adminpanel directory 2. execute: docker run --rm --pull always -v $(pwd):/project -it ghcr.io/typo3-documentation/render-guides:latest --config=Documentation -
Chris Müller commented on patch set 2 03/01/24, 12:17
-
Benni Mack voted on patch set 2 CR +1 V +1 03/01/24, 15:39
-
Garvin Hicking commented on patch set 2 03/01/24, 18:06
is the backport down to 12 and 11 intentional? That would mean rendering all these versions with the new one, are we prime-time already for core-docs? If so, when backporting, the guides.xml needs adaptation then for the relative correct branches. -
Chris Müller commented on patch set 2 03/01/24, 18:42
Reply
IMHO we should go for the LTS versions - we have to start anyway at some time. The rendered manual looked good and we can retrigger the rendering later, if we really have to. Otherwise we have to start a review again for the LTS versions. And I assume, Lina will take care of adapting the version in the settings on backporting. -
Lina Wolf commented on patch set 2 03/01/24, 19:26
Reply
I will take care of the backporting -
Lina Wolf voted on patch set 2 CR +2 V +2 03/01/24, 19:26
-
Lina Wolf merged patch set 3 03/01/24, 19:26
Index.rst:40