83174[TASK] Format fluid format tags consistently
Commit message
Review
-
Code review CR +2 Done
- Simon Praetorius +2
- Oliver Klee +1
-
Verified V +2 Done
- Simon Praetorius +2
- core-ci +1 CI
Issues 1
Files 75
- typo3/sysext/backend/Resources/Private/Layouts/Module.html+1 −2
- typo3/sysext/backend/Resources/Private/Partials/About/CoreTeam.html+5 −0
- typo3/sysext/backend/Resources/Private/Partials/About/Credits.html+5 −0
- typo3/sysext/backend/Resources/Private/Partials/About/Donation.html+5 −0
- typo3/sysext/backend/Resources/Private/Partials/About/Extensions.html+5 −0
- typo3/sysext/backend/Resources/Private/Partials/Email/PasswordReset/ClosingParagraph.html+5 −0
- typo3/sysext/backend/Resources/Private/Partials/Menus/SelectBoxJumpMenu.html+11 −4
- typo3/sysext/backend/Resources/Private/Partials/Mfa/SetupInstructions.html+5 −0
- typo3/sysext/backend/Resources/Private/Partials/MultiRecordSelection/Actions.html+2 −3
- typo3/sysext/backend/Resources/Private/Partials/PageLayout/Grid/Column.html+5 −0
- typo3/sysext/backend/Resources/Private/Partials/PageLayout/Grid/ColumnHeader.html+6 −0
- typo3/sysext/backend/Resources/Private/Partials/PageLayout/RecordDefault/Footer.html+5 −0
- typo3/sysext/backend/Resources/Private/Partials/PageLayout/Grid.html+5 −0
- typo3/sysext/backend/Resources/Private/Partials/PageLayout/LanguageColumns.html+7 −0
- typo3/sysext/backend/Resources/Private/Partials/PageLayout/Record.html+6 −0
- typo3/sysext/backend/Resources/Private/Partials/DocHeader.html+5 −0
- typo3/sysext/backend/Resources/Private/Templates/ContentElement/ElementInformation.html+0 −4
- typo3/sysext/backend/Resources/Private/Templates/ElementBrowser/Page.html+0 −1
- typo3/sysext/backend/Resources/Private/Templates/Form/EditDocument.html+0 −5
- typo3/sysext/backend/Resources/Private/Templates/Form/OuterWrapContainer.html+0 −2
Show 55 more files
- typo3/sysext/backend/Resources/Private/Templates/Mfa/Edit.html+0 −3
- typo3/sysext/backend/Resources/Private/Templates/Page/SortSubPages.html+0 −9
- typo3/sysext/backend/Resources/Private/Templates/PageLayout/PageLayout.html+5 −1
- typo3/sysext/backend/Resources/Private/Templates/PageLayout/PageModule.html+0 −8
- typo3/sysext/backend/Resources/Private/Templates/PageTsConfig/Active.html+0 −4
- typo3/sysext/backend/Resources/Private/Templates/PageTsConfig/RecordsOverview.html+0 −2
- typo3/sysext/backend/Resources/Private/Templates/ToolbarItems/ShortcutToolbarItemDropDown.html+6 −0
- typo3/sysext/backend/Resources/Private/Templates/ToolbarItems/SystemInformationDropDown.html+5 −1
- typo3/sysext/backend/Resources/Private/Templates/RecordList.html+0 −1
- typo3/sysext/beuser/Resources/Private/Templates/Permission/Index.html+1 −3
- typo3/sysext/extensionmanager/Resources/Private/Partials/List/Distribution.html+7 −1
- typo3/sysext/extensionmanager/Resources/Private/Partials/List/TerShowVersionsTable.html+7 −2
- typo3/sysext/extensionmanager/Resources/Private/Partials/List/TerTable.html+7 −1
- typo3/sysext/extensionmanager/Resources/Private/Templates/Distribution/Show.html+7 −13
- typo3/sysext/extensionmanager/Resources/Private/Templates/ExtensionComposerStatus/List.html+0 −5
- typo3/sysext/extensionmanager/Resources/Private/Templates/List/ShowAllVersions.html+0 −5
- typo3/sysext/filelist/Resources/Private/Templates/ElementBrowser/CreateFolder.html+0 −1
- typo3/sysext/filelist/Resources/Private/Templates/ElementBrowser/Files.html+0 −1
- typo3/sysext/filelist/Resources/Private/Templates/ElementBrowser/Folder.html+0 −3
- typo3/sysext/filelist/Resources/Private/Templates/File/CreateFile.html+0 −3
- typo3/sysext/filelist/Resources/Private/Templates/File/EditFile.html+0 −3
- typo3/sysext/filelist/Resources/Private/Templates/LinkHandler/File.html2+1 −1
- typo3/sysext/filelist/Resources/Private/Templates/LinkHandler/Folder.html2+1 −1
- typo3/sysext/fluid_styled_content/Resources/Private/Templates/Html.html+2 −2
- typo3/sysext/fluid_styled_content/Resources/Private/Templates/MenuAbstract.html+1 −2
- typo3/sysext/fluid_styled_content/Resources/Private/Templates/Shortcut.html+2 −2
- typo3/sysext/fluid_styled_content/Resources/Private/Templates/Text.html+1 −2
- typo3/sysext/fluid_styled_content/Resources/Private/Templates/Textmedia.html+2 −6
- typo3/sysext/fluid_styled_content/Resources/Private/Templates/Textpic.html+2 −6
- typo3/sysext/fluid_styled_content/Tests/Functional/Rendering/Fixtures/FluidTemplate.html+2 −0
- typo3/sysext/form/Resources/Private/Frontend/Templates/Finishers/Email/Default.html+8 −0
- typo3/sysext/form/Resources/Private/FrontendVersion2/Partials/Field/Field.html+4 −1
- typo3/sysext/form/Resources/Private/FrontendVersion2/Partials/AdvancedPassword.html+6 −6
- typo3/sysext/form/Resources/Private/FrontendVersion2/Partials/MultiCheckbox.html+0 −2
- typo3/sysext/form/Resources/Private/Templates/Backend/FormEditor/Index.html+0 −1
- typo3/sysext/impexp/Resources/Private/Partials/Export/Configuration.html+0 −16
- typo3/sysext/impexp/Resources/Private/Partials/Import/MetaData.html+0 −4
- typo3/sysext/impexp/Resources/Private/Partials/Preview.html+0 −2
- typo3/sysext/indexed_search/Resources/Private/Templates/Administration/ExternalDocuments.html+0 −1
- typo3/sysext/indexed_search/Resources/Private/Templates/Administration/Pages.html+0 −1
- typo3/sysext/indexed_search/Resources/Private/Templates/Administration/Statistic.html+1 −2
- typo3/sysext/indexed_search/Resources/Private/Templates/Administration/StatisticDetails.html+0 −2
- typo3/sysext/indexed_search/Resources/Private/Templates/Search/Search.html+0 −1
- typo3/sysext/info/Resources/Private/Layouts/Module.html+1 −4
- typo3/sysext/info/Resources/Private/Templates/PageInformation.html+1 −8
- typo3/sysext/info/Resources/Private/Templates/TranslationStatus.html+0 −3
- typo3/sysext/install/Resources/Private/Partials/Upgrade/UpgradeDocs/PanelItem.html+2 −2
- typo3/sysext/lowlevel/Resources/Private/Templates/Configuration.html+0 −7
- typo3/sysext/lowlevel/Resources/Private/Templates/CustomSearch.html+3 −6
- typo3/sysext/lowlevel/Resources/Private/Templates/RecordStatistics.html+0 −4
- typo3/sysext/lowlevel/Resources/Private/Templates/Relations.html+0 −3
- typo3/sysext/scheduler/Resources/Private/Partials/TaskList.html+21 −21
- typo3/sysext/setup/Resources/Private/Templates/Main.html+1 −7
- typo3/sysext/tstemplate/Resources/Private/Partials/ActiveTree.html+0 −3
- typo3/sysext/workspaces/Resources/Private/Templates/Email/StageChangeNotification.html+8 −4
Review log 1318
-
Simon Schaufelberger uploaded patch set 1 03/01/24, 13:23
-
core-ci voted on patch set 1 V -1 03/01/24, 13:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53753
-
Garvin Hicking commented on patch set 1 CR -1 03/01/24, 13:34
My opinion: I dislike the inline notation and try to avoid it, when not needed for HTML validity in a fluid template. Because: It removes IDE syntax highlighting as XML tag, and it's counter intuitive to read because the variable comes before "what's happening to it". So for most of these changes, even though it achieves consistency, it gets consistingly ugly (no offense). ;-) -
Simon Schaufelberger commented on patch set 1 03/01/24, 13:44
Reply
The advantages is that it removes a lot of nesting and nesting is harder to read than the arrow notation imho. Since there is no big magic happening but just formatting, I consider it an improvement. Concerning IDE support. If you install the plugin from sgalinski, you will get great support and can even click on the tag and it will bring you straight to the class. -
Simon Praetorius commented on patch set 1 CR -1 V -1 03/01/24, 13:47
Thank you for your effort. I like the changes to the namespace declaration, since it allows for better autocompletion and validation. However, I tend to agree with Garvin that the other unification changes aren‘t really necessary or helpful. Maybe it makes sense to start only with the namespace changes? I think that this is a clear win. -
Simon Schaufelberger uploaded patch set 2
CR -1V -103/01/24, 14:27 -
core-ci voted on patch set 2 V -1 03/01/24, 14:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53757
-
core-ci commented on patch set 2 03/01/24, 14:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53757
-
Simon Schaufelberger uploaded patch set 3
V -103/01/24, 15:10 -
Simon Schaufelberger uploaded patch set 4 03/01/24, 15:11
-
core-ci voted on patch set 3 V +1 03/01/24, 15:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53759
-
core-ci voted on patch set 4 V +1 03/01/24, 15:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53760
-
Simon Schaufelberger commented on patch set 4 03/02/24, 21:12
Reply
Done -
Oliver Klee voted on patch set 4 CR +1 03/03/24, 09:42
-
Simon Praetorius commented on patch set 4 03/03/24, 16:59
File.html:3this doesn't seem to be used hereFolder.html:3this doesn't seem to be used here -
Simon Praetorius commented on patch set 4 CR +2 V +2 03/03/24, 17:04
File.html:3ReplyAh, my mistake. Never mind.Folder.html:3ReplyAh, my mistake. Never mind. -
Simon Praetorius merged patch set 5 03/03/24, 17:05
-
Benjamin Franzke wrote 03/05/24, 14:35
Created a revert of this change as I50e4b27adad119fdd9634276a60f1d6200838f8a