Review main Merged

83174[TASK] Format fluid format tags consistently

Simon Schaufelberger CR +2 V +2 Hard +198 −224 updated 03/05/24, 14:35

Commit message

For some fluid templates, the namespace has been migrated from the
"{namespace}" notation to the html tag notation.

Additionally, some formatting was applied.

Review

  • Code review CR +2 Done
    • Simon Praetorius +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Simon Praetorius +2
    • core-ci +1 CI

Issues 1

Files 75

Show 55 more files

Review log 1318

  1. Simon Schaufelberger uploaded patch set 1 03/01/24, 13:23

  2. core-ci voted on patch set 1 V -1 03/01/24, 13:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53753

  3. Garvin Hicking commented on patch set 1 CR -1 03/01/24, 13:34

    My opinion: I dislike the inline notation and try to avoid it, when not needed for HTML validity in a fluid template. Because: It removes IDE syntax highlighting as XML tag, and it's counter intuitive to read because the variable comes before "what's happening to it". So for most of these changes, even though it achieves consistency, it gets consistingly ugly (no offense). ;-)
  4. Simon Schaufelberger commented on patch set 1 03/01/24, 13:44

    Reply

    The advantages is that it removes a lot of nesting and nesting is harder to read than the arrow notation imho. Since there is no big magic happening but just formatting, I consider it an improvement. Concerning IDE support. If you install the plugin from sgalinski, you will get great support and can even click on the tag and it will bring you straight to the class.
  5. Simon Praetorius commented on patch set 1 CR -1 V -1 03/01/24, 13:47

    Thank you for your effort. I like the changes to the namespace declaration, since it allows for better autocompletion and validation. However, I tend to agree with Garvin that the other unification changes aren‘t really necessary or helpful. Maybe it makes sense to start only with the namespace changes? I think that this is a clear win.
  6. Simon Schaufelberger uploaded patch set 2 CR -1 V -1 03/01/24, 14:27

  7. core-ci voted on patch set 2 V -1 03/01/24, 14:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53757

  8. core-ci commented on patch set 2 03/01/24, 14:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53757

  9. Simon Schaufelberger uploaded patch set 3 V -1 03/01/24, 15:10

  10. Simon Schaufelberger uploaded patch set 4 03/01/24, 15:11

  11. core-ci voted on patch set 3 V +1 03/01/24, 15:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53759

  12. core-ci voted on patch set 4 V +1 03/01/24, 15:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53760

  13. Simon Schaufelberger commented on patch set 4 03/02/24, 21:12

    Reply

    Done
  14. Oliver Klee voted on patch set 4 CR +1 03/03/24, 09:42

  15. Simon Praetorius commented on patch set 4 03/03/24, 16:59

    File.html:3

    this doesn't seem to be used here

    Folder.html:3

    this doesn't seem to be used here
  16. Simon Praetorius commented on patch set 4 CR +2 V +2 03/03/24, 17:04

    File.html:3 Reply

    Ah, my mistake. Never mind.

    Folder.html:3 Reply

    Ah, my mistake. Never mind.
  17. Simon Praetorius merged patch set 5 03/03/24, 17:05

  18. Benjamin Franzke wrote 03/05/24, 14:35

    Created a revert of this change as I50e4b27adad119fdd9634276a60f1d6200838f8a