Review main Merged

83176[TASK] Simplify DH by inlining SlugEnricher

Christian Kuhn CR +2 V +2 Normal +77 −3 updated 03/03/24, 12:32

Commit message

DataHandler related class SlugEnricher is a scary
sounding class name for a simple operation that
sets incoming TCA type=slug fields to empty string
if not provided, to trigger slug calculation later.

The patch inlines that operation into DataHandler,
avoiding the class with three methods, a property,
and a set of array_* function calls, substituting
it with three foreach(), two if() and a helper
method that can be re-used.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 812

  1. Christian Kuhn uploaded patch set 1 03/01/24, 14:38

  2. core-ci voted on patch set 1 V -1 03/01/24, 14:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53758

  3. Christian Kuhn uploaded patch set 2 V -1 03/02/24, 08:30

  4. core-ci voted on patch set 2 V -1 03/02/24, 08:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53769

  5. Christian Kuhn rebased onto patch set 3 V -1 03/02/24, 10:45

  6. core-ci voted on patch set 3 V +1 03/02/24, 10:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53773

  7. Christian Kuhn uploaded patch set 4 V +1 03/02/24, 11:13

  8. core-ci voted on patch set 4 V +1 03/02/24, 11:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53774

  9. Benni Mack voted on patch set 4 CR +1 V +1 03/02/24, 21:54

  10. Anja Leichsenring voted on patch set 4 CR +1 V +1 03/03/24, 09:13

  11. Christian Kuhn voted on patch set 4 CR +2 V +2 03/03/24, 12:32

  12. Christian Kuhn merged patch set 5 03/03/24, 12:32