Review main Merged

83177[BUGFIX] Use correct `DateInterval` objects in `RotatingFileWriterTest`

Andreas Kienast CR +2 V +2 Normal +24 −34 updated 03/02/24, 10:44

Commit message

The `RotatingFileWriterTest` previously used a timestamp-based
calculation to mock file names. This approach conflicts with the
`DateInterval`-based calculation and might lead to false-negative test
results. This commit updates the test cases by using the interval-based
calculation now.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Markus Klein +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Markus Klein +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 911

  1. Andreas Kienast uploaded patch set 1 03/02/24, 10:12

  2. Markus Klein voted on patch set 1 CR +1 03/02/24, 10:16

  3. core-ci voted on patch set 1 V +1 03/02/24, 10:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53771

  4. Christian Kuhn commented on patch set 1 CR -1 03/02/24, 10:27

    RotatingFileWriterTest.php:161

    good opportunity to combine the two data providers into on. will push.
  5. Christian Kuhn uploaded patch set 2 CR +1 V +1 03/02/24, 10:27

  6. Christian Kuhn voted on patch set 2 CR +1 V +1 03/02/24, 10:27

  7. Andreas Kienast commented on patch set 2 03/02/24, 10:29

    RotatingFileWriterTest.php:161 Reply

    Thanks. I wasn't completely sure about this.
  8. core-ci voted on patch set 2 V +1 03/02/24, 10:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53772

  9. Markus Klein voted on patch set 2 CR +1 V +1 03/02/24, 10:39

  10. Christian Kuhn voted on patch set 2 CR +2 V +2 03/02/24, 10:44

  11. Christian Kuhn merged patch set 3 03/02/24, 10:44