83178[TASK] Replace GeneralUtility::hmac usage in ext:fluid
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Christian Kuhn +1
-
Verified V +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 1
Review log 79
-
Torben Hansen uploaded patch set 1 03/02/24, 12:46
-
core-ci voted on patch set 1 V -1 03/02/24, 12:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53776
-
Torben Hansen rebased onto patch set 2
V -103/02/24, 12:58 -
Oliver Klee voted on patch set 2 CR +1 03/02/24, 13:00
-
core-ci voted on patch set 2 V +1 03/02/24, 13:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53777
-
Christian Kuhn commented on patch set 2 CR +1 03/04/24, 07:38
i would love to see DI being used for the hashService since that VH is not "renderStatic", but i'm not 100% sure this actually works with fluid ... would be great to try this, but I could also live without it for now. -
Christian Kuhn commented on patch set 2 V +1 03/04/24, 09:04
Reply
well. AbstractTagBasedViewHelper pollutes __construct(), but not in a too evil way ... i don't care too much at the moment and think we should just go with proposed solution. -
Stefan Bürk voted on patch set 2 CR +2 V +2 03/04/24, 12:16
-
Stefan Bürk merged patch set 3 03/04/24, 12:16