Review main Merged

83183[FEATURE] Auto create DB fields from TCA for type "input"

Christian Kuhn CR +2 V +2 Expert +279 −850 updated 06/14/24, 10:58

Commit message

Tables with TCA columns set to type="input" do not
need an ext_tables.sql entry anymore. The core now
creates this field automatically.

This is one of many patches in this area: The v13 goal
is to obsolete ext_tables.sql in most cases by
creating default "business" fields of TCA tables
automatically.

The patch adds the main magic in class DefaultTcaSchema
and removes own ext_tables.sql definitions having
type=input.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 61

Show 41 more files

Review log 3767

Show 2142 earlier messages
  1. Christian Kuhn uploaded patch set 1 03/04/24, 07:30

  2. Christian Kuhn marked it work in progress 03/04/24, 07:30

  3. core-ci voted on patch set 1 V -1 03/04/24, 07:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53805

  4. Christian Kuhn uploaded patch set 2 V -1 03/20/24, 13:27

  5. Christian Kuhn marked it ready for review 03/20/24, 13:27

  6. core-ci voted on patch set 2 V -1 03/20/24, 13:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54722

  7. Christian Kuhn uploaded patch set 3 V -1 03/20/24, 14:49

  8. core-ci voted on patch set 3 V -1 03/20/24, 14:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54726

  9. Christian Kuhn uploaded patch set 4 V -1 03/20/24, 17:33

  10. core-ci voted on patch set 4 V -1 03/20/24, 17:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54737

  11. Christian Kuhn uploaded patch set 5 V -1 03/20/24, 18:12

  12. core-ci voted on patch set 5 V -1 03/20/24, 18:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54740

  13. Christian Kuhn uploaded patch set 6 V -1 03/20/24, 19:31

  14. core-ci voted on patch set 6 V -1 03/20/24, 19:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54744

  15. Christian Kuhn uploaded patch set 7 V -1 03/20/24, 20:56

  16. core-ci voted on patch set 7 V -1 03/20/24, 21:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54745

  17. Christian Kuhn uploaded patch set 8 V -1 03/20/24, 21:03

  18. core-ci voted on patch set 8 V -1 03/20/24, 21:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54746

  19. Christian Kuhn uploaded patch set 9 V -1 03/20/24, 21:11

  20. Christian Kuhn uploaded patch set 10 03/20/24, 21:13

  21. core-ci voted on patch set 9 V -1 03/20/24, 21:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54747

  22. core-ci voted on patch set 10 V -1 03/20/24, 21:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54751

  23. Christian Kuhn uploaded patch set 11 V -1 04/01/24, 09:29

  24. core-ci voted on patch set 11 V -1 04/01/24, 09:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55111

  25. Christian Kuhn uploaded patch set 12 V -1 04/02/24, 05:39

  26. core-ci voted on patch set 12 V +1 04/02/24, 05:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55122

  27. Christian Kuhn uploaded patch set 13 V +1 04/02/24, 07:21

  28. core-ci voted on patch set 13 V -1 04/02/24, 07:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55128

  29. Christian Kuhn uploaded patch set 14 V -1 04/02/24, 08:18

  30. core-ci voted on patch set 14 V +1 04/02/24, 08:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55132

  31. Christian Kuhn uploaded patch set 15 V +1 04/02/24, 08:46

  32. core-ci voted on patch set 15 V +1 04/02/24, 08:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55137

  33. Christian Kuhn uploaded patch set 16 V +1 04/02/24, 08:59

  34. core-ci voted on patch set 16 V +1 04/02/24, 09:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55139

  35. Christian Kuhn uploaded patch set 17 V +1 04/02/24, 09:43

  36. core-ci voted on patch set 17 V +1 04/02/24, 09:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55144

  37. Christian Kuhn rebased onto patch set 18 V +1 04/10/24, 18:46

  38. core-ci voted on patch set 18 V +1 04/10/24, 18:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55708

  39. core-ci voted on patch set 18 V -1 04/10/24, 19:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55709

  40. Christian Kuhn rebased onto patch set 19 V -1 06/10/24, 11:30

  41. core-ci voted on patch set 19 V +1 06/10/24, 11:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58997

  42. core-ci commented on patch set 19 06/10/24, 12:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59001

  1. Stefan Bürk uploaded patch set 20 V +1 06/10/24, 12:44

  2. Stefan Bürk uploaded patch set 21 06/10/24, 12:50

  3. core-ci voted on patch set 20 V -1 06/10/24, 12:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59007

  4. core-ci voted on patch set 21 V -1 06/10/24, 13:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59011

  5. Stefan Bürk uploaded patch set 22 V -1 06/10/24, 15:09

  6. core-ci voted on patch set 22 V +1 06/10/24, 15:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59029

  7. Christian Kuhn rebased onto patch set 23 V +1 06/12/24, 11:35

  8. core-ci voted on patch set 23 V +1 06/12/24, 11:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59314

  9. Christian Kuhn uploaded patch set 24 V +1 06/12/24, 15:48

  10. core-ci voted on patch set 24 V +1 06/12/24, 15:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59344

  11. Christian Kuhn rebased onto patch set 25 V +1 06/13/24, 15:51

  12. core-ci voted on patch set 25 V +1 06/13/24, 15:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59506

  13. Christian Kuhn uploaded patch set 26 V +1 06/13/24, 16:03

  14. core-ci voted on patch set 26 V -1 06/13/24, 16:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59508

  15. Christian Kuhn uploaded patch set 27 V -1 06/13/24, 16:11

  16. Christian Kuhn updated the commit message in patch set 28 06/13/24, 16:14

  17. core-ci voted on patch set 27 V +1 06/13/24, 16:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59511

  18. core-ci voted on patch set 28 V +1 06/13/24, 16:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59514

  19. Stefan Bürk voted on patch set 28 CR +1 V +1 06/13/24, 17:06

  20. Benni Mack commented on patch set 28 06/13/24, 17:25

    ext_tables.sql:114

    why do you remove the comment above? I think this is valuable information for future-self
  21. Benni Mack commented on patch set 28 CR +2 V +2 06/13/24, 18:10

    ext_tables.sql:114 Reply

    Done
  22. Benni Mack voted on patch set 28 CR +1 V +1 06/13/24, 18:10

  23. Christian Kuhn voted on patch set 28 CR +2 V +2 06/13/24, 18:12

  24. Christian Kuhn merged patch set 29 06/13/24, 18:12

  25. Christian Kuhn commented on patch set 29 06/14/24, 10:58

    wrong Resolves ... correct one: Resolves: #104098