Review main Merged

83191[BUGFIX] Add missing file search to file link handler

Oli Bartsch CR +2 V +2 Easy +27 −14 updated 03/04/24, 18:30

Commit message

The FileLinkHandler, used to select a file
in the link wizard does now also allow to
search for files, like it's also possible
in the FileBrowser already.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Andreas Nedbal +1
    • Andreas Kienast +1
    • Susi Moog +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Andreas Nedbal +1
    • Andreas Kienast +1
    • Susi Moog +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1012

  1. Oli Bartsch uploaded patch set 1 03/04/24, 11:47

  2. core-ci voted on patch set 1 V +1 03/04/24, 11:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53832

  3. Susi Moog voted on patch set 1 CR +1 V +1 03/04/24, 12:37

  4. Andreas Nedbal commented on patch set 1 V -1 03/04/24, 12:51

    Using the file search on link inputs works fine, but when using the link handler in RTEs, it throws an exception: > #1476107295 TYPO3\CMS\Core\Error\Exception PHP Warning: Undefined array key "editorId" in /var/www/html/typo3/sysext/rte_ckeditor/Classes/Controller/BrowseLinksController.php line 102
  5. Oli Bartsch uploaded patch set 2 CR +1 V +1 03/04/24, 13:52

  6. Oli Bartsch commented on patch set 2 03/04/24, 13:53

    Reply

    Thanks for testing. fixed it :)
  7. Andreas Nedbal voted on patch set 2 CR +1 V +1 03/04/24, 13:55

  8. Susi Moog voted on patch set 2 CR +1 V +1 03/04/24, 13:55

  9. core-ci voted on patch set 2 V +1 03/04/24, 13:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53849

  10. Andreas Kienast voted on patch set 2 CR +1 V +1 03/04/24, 15:33

  11. Oli Bartsch voted on patch set 2 CR +2 V +2 03/04/24, 18:30

  12. Oli Bartsch merged patch set 3 03/04/24, 18:30