Review main Merged

83197[TASK] Remove jQuery from workspaces preview link modal

Andreas Nedbal CR +2 V +2 Easy +15 −9 updated 03/05/24, 10:46

Commit message

Review

  • Code review CR +2 Done
    • Andreas Nedbal +2
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Nedbal +2
    • Andreas Kienast +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1521

  1. Andreas Nedbal uploaded patch set 1 03/04/24, 14:57

  2. Andreas Nedbal rebased onto patch set 2 03/04/24, 14:58

    The following files contain Git conflicts: * typo3/sysext/workspaces/Resources/Public/JavaScript/backend.js
  3. Andreas Nedbal uploaded patch set 3 03/04/24, 14:59

  4. Andreas Nedbal marked it ready for review 03/04/24, 14:59

  5. core-ci voted on patch set 1 V +1 03/04/24, 15:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53863

  6. core-ci voted on patch set 3 V +1 03/04/24, 15:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53865

  7. Andreas Kienast commented on patch set 3 03/04/24, 15:07

    backend.ts:1063

    `list.append(title, listItem)` should also work.
  8. Andreas Nedbal uploaded patch set 4 V +1 03/04/24, 15:09

  9. core-ci voted on patch set 2 V -1 03/04/24, 15:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53864

  10. Andreas Nedbal commented on patch set 4 03/04/24, 15:09

    backend.ts:1063 Reply

    Done
  11. core-ci voted on patch set 4 V +1 03/04/24, 15:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53870

  12. Benni Mack voted on patch set 4 CR +1 V +1 03/04/24, 17:58

  13. Andreas Nedbal rebased onto patch set 5 CR +1 V +1 03/05/24, 07:50

    The following files contain Git conflicts: * typo3/sysext/workspaces/Resources/Public/JavaScript/backend.js
  14. Andreas Nedbal uploaded patch set 6 03/05/24, 07:53

  15. Andreas Nedbal marked it ready for review 03/05/24, 07:53

  16. core-ci voted on patch set 5 V -1 03/05/24, 07:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53917

  17. core-ci voted on patch set 6 V +1 03/05/24, 07:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53918

  18. Andreas Kienast voted on patch set 6 CR +1 V +1 03/05/24, 09:12

  19. Benni Mack voted on patch set 6 CR +1 V +1 03/05/24, 10:45

  20. Andreas Nedbal voted on patch set 6 CR +2 V +2 03/05/24, 10:46

  21. Andreas Nedbal merged patch set 7 03/05/24, 10:46