Review main Merged

83198[DOCS] Add regex example to target column referencing capturing groups

Josef Glatz CR +2 V +2 Easy +4 −0 updated 03/07/24, 05:24

Commit message

This patch adds necessary hints about regex capturing groups
to the documentation of the field target of EXT:redirects.

Both columns (source_path and _target) referencing the
regular expression functionality from now on.

Review

  • Code review CR +2 Done
    • Lina Wolf +2
    • Garvin Hicking +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Lina Wolf +2
    • Garvin Hicking +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 79

  1. Josef Glatz uploaded patch set 1 03/04/24, 15:07

  2. Josef Glatz commented on patch set 1 03/04/24, 15:08

    This change is ready for review.
  3. Josef Glatz updated the commit message in patch set 2 03/04/24, 15:11

  4. core-ci voted on patch set 1 V +1 03/04/24, 15:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53869

  5. core-ci voted on patch set 2 V +1 03/04/24, 15:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53872

  6. Simon Schaufelberger voted on patch set 2 CR +1 V +1 03/05/24, 00:00

  7. Garvin Hicking voted on patch set 2 CR +1 V +1 03/06/24, 22:07

  8. Lina Wolf commented on patch set 2 CR +2 V +2 03/07/24, 05:23

    The whole section would need a overhaul but that would be beyond the scope of this change so let's do that in a follow up some time.
  9. Lina Wolf merged patch set 3 03/07/24, 05:24