Review main Merged

83199[FEATURE] Add language filter for list module

Marvin Buchmann CR +2 V +2 Hard +873 −19 updated 10/30/25, 14:47

Commit message

Adds a language filter to the list module’s docHeader to allow
reducing the listed elements to a specific language.
This increases usability of the list module when editing records
of a specific language.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 10

Review log 6098

Show 4373 earlier messages
  1. Marvin Buchmann uploaded patch set 1 03/04/24, 16:59

  2. Marvin Buchmann uploaded patch set 2 03/04/24, 17:05

  3. core-ci voted on patch set 1 V -1 03/04/24, 17:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53879

  4. Marvin Buchmann rebased onto patch set 3 03/04/24, 17:09

  5. core-ci voted on patch set 2 V -1 03/04/24, 17:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53880

  6. core-ci voted on patch set 3 V -1 03/04/24, 17:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53881

  7. Marvin Buchmann rebased onto patch set 4 V -1 03/04/24, 18:05

  8. core-ci voted on patch set 4 V -1 03/04/24, 18:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53884

  9. Marvin Buchmann rebased onto patch set 5 V -1 03/04/24, 18:13

  10. core-ci voted on patch set 5 V -1 03/04/24, 18:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53886

  11. Marvin Buchmann uploaded patch set 6 V -1 03/04/24, 19:07

  12. core-ci voted on patch set 6 V -1 03/04/24, 19:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53894

  13. Benni Mack commented on patch set 6 03/04/24, 19:15

    DatabaseRecordList.php:2403

    we don't do yoda
  14. Marvin Buchmann uploaded patch set 7 V -1 03/04/24, 19:28

  15. core-ci voted on patch set 7 V +1 03/04/24, 19:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53897

  16. Benni Mack commented on patch set 7 CR -1 03/04/24, 21:20

    Feature.rst is missing
  17. Marvin Buchmann uploaded patch set 8 CR -1 V +1 03/04/24, 21:48

  18. core-ci voted on patch set 8 V +1 03/04/24, 21:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53909

  19. Josef Glatz commented on patch set 8 03/05/24, 03:32

    does such a feature needs specific tests? like e2e or acceptance?
  20. Benni Mack uploaded patch set 9 V +1 03/05/24, 11:57

  21. Benni Mack commented on patch set 9 03/05/24, 11:58

    Reply

    I think we should add this, but in a separate patch to also have such Acceptance Tests in the Page Module as well.

    DatabaseRecordList.php:2403 Reply

    Done
  22. Benni Mack voted on patch set 9 CR +1 V +1 03/05/24, 11:59

  23. core-ci voted on patch set 9 V -1 03/05/24, 12:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53939

  24. Marvin Buchmann uploaded patch set 10 CR +1 V +1 03/05/24, 14:01

  25. core-ci voted on patch set 10 V -1 03/05/24, 14:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53948

  26. Marvin Buchmann uploaded patch set 11 V -1 03/05/24, 14:39

  27. core-ci voted on patch set 9 V -1 03/05/24, 14:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53939

  28. core-ci voted on patch set 11 V -1 03/05/24, 14:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53954

  29. Andreas Kienast uploaded patch set 12 V -1 03/05/24, 15:16

  30. Andreas Kienast uploaded patch set 13 03/05/24, 15:17

  31. core-ci voted on patch set 12 V -1 03/05/24, 15:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53957

  32. core-ci voted on patch set 13 V -1 03/05/24, 15:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53958

  33. Marvin Buchmann uploaded patch set 14 V -1 03/05/24, 15:34

  34. core-ci voted on patch set 14 V -1 03/05/24, 15:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53960

  35. core-ci commented on patch set 14 03/05/24, 15:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53960

  36. core-ci voted on patch set 14 V +1 03/05/24, 15:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53960

  37. Benni Mack voted on patch set 14 CR +1 V +1 03/05/24, 16:00

  38. Christian Kuhn voted on patch set 14 CR -1 03/05/24, 18:24

  39. Josef Glatz wrote 03/06/24, 05:22

    Removed cc Josef Glatz.
  40. Oli Bartsch commented on patch set 14 CR -1 03/06/24, 09:02

    RecordListController.php:76

    I think we don't need this as class property. Also the naming might be improved.

    RecordListController.php:96

    I don't see any reason for this method. Let's do the initialization in the `mainAction()`.

    RecordListController.php:101

    I think we don't need this as class property. We could just pass the info to the two corresponding methods.

    RecordListController.php:268

    I think we should try to optimize this the whole methods code instead of just duplicating it from page module.
  41. Marvin Buchmann uploaded patch set 15 CR +1 V +1 03/06/24, 14:54

  42. Marvin Buchmann commented on patch set 15 03/06/24, 15:00

    Reply

    @typo3@josefglatz.at I agree. As there are no acceptance tests by now, I added a functional test to check if the

    RecordListController.php:76 Reply

    Done

    RecordListController.php:96 Reply

    Done

    RecordListController.php:101 Reply

    Done

    RecordListController.php:268 Reply

    The method now only fetches page translations for available site languages instead of fetching all existing translations and only using the required ones. Is the "-1" option what should be refactored or which aspect was this aimed at?

    DatabaseRecordList.php:2403 Reply

    Done
  43. core-ci voted on patch set 15 V +1 03/06/24, 15:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54044

  44. Marvin Buchmann commented on patch set 15 03/06/24, 15:03

    Reply

    @typo3@josefglatz.at Sorry, the last message was an earlier draft that Gerrit still had saved and sent now. I just added an acceptance test.
  45. Marvin Buchmann wrote 03/06/24, 15:03

    Removed cc Josef Glatz.
  46. Guido Schmechel commented on patch set 15 V -1 03/11/24, 20:53

    First of all: Nice idea for a feature! Here is some brief feedback from my side 1) When I search for something, my language selection is lost 2) I had created a SysFolder with two categories. One EN (Language UID 0), one NO (Language UID 1). When I filter by EN everything works, with NO the English category is also displayed.
  47. Marvin Buchmann commented on patch set 15 03/12/24, 06:49

    Reply

    The idea came from Frank, I guess. 😄 Thanks a lot for testing! I'll see when I can get back to this. Might take a couple of weeks, but I'll check on your feedback as soon as I can!
  48. Marvin Buchmann uploaded patch set 16 V +1 04/10/24, 14:03

  49. core-ci voted on patch set 16 V -1 04/10/24, 14:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55687

  50. Marvin Buchmann commented on patch set 16 04/10/24, 14:28

    Reply

    1) I just fixed it. 2) Currently it's intended that the default language records are shown as they can be relevant for the translated record (e.g. with fields excluded from translations) - and if there is no translation, one might want to create one. The options in "translate to" are reduced to the filtered language to tidy up the view when there are lots of languages.

    RecordListController.php:268 Reply

    Just had another look on this. I think there should be a solution that works across modules. Something like ButtonBar::makeLanguageButton() that centralizes the creation of language selects in the backend. This one is copied from the "page" module, the "view" module for example has another implementation. I guess a separate patch creating a solution that works for all of them would be the way to go.
  51. Marvin Buchmann uploaded patch set 17 V -1 04/10/24, 14:46

  52. core-ci voted on patch set 17 V +1 04/10/24, 14:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55688

  53. Chris Müller uploaded patch set 18 V +1 05/02/24, 17:51

  54. core-ci voted on patch set 18 V -1 05/02/24, 18:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57110

  55. core-ci commented on patch set 18 05/03/24, 07:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57110

  56. core-ci commented on patch set 18 05/03/24, 09:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57110

  57. Chris Müller rebased onto patch set 19 V -1 05/03/24, 10:17

  58. core-ci voted on patch set 19 V -1 05/03/24, 10:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57170

  59. Chris Müller rebased onto patch set 20 V -1 08/01/24, 18:59

  60. core-ci voted on patch set 20 V +1 08/01/24, 19:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62611

  61. Benni Mack commented on patch set 21 V +1 09/05/24, 07:55

    Published edit on patch set 20.
  62. core-ci voted on patch set 21 V -1 09/05/24, 08:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64842

  63. Benni Mack rebased onto patch set 22 V -1 01/22/25, 08:28

  64. core-ci voted on patch set 22 V -1 01/22/25, 08:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72828

  65. Benni Mack marked it work in progress 03/28/25, 12:18

  66. Benni Mack uploaded patch set 23 V -1 07/29/25, 21:11

  67. Benni Mack commented on patch set 24 07/29/25, 21:16

    Published edit on patch set 23.
  68. Benni Mack rebased onto patch set 25 07/29/25, 21:16

  69. Benni Mack marked it ready for review 07/29/25, 21:16

  70. core-ci voted on patch set 23 V -1 07/29/25, 21:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82513

  71. core-ci voted on patch set 24 V -1 07/29/25, 21:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82514

  72. core-ci voted on patch set 25 V -1 07/29/25, 21:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82515

  73. Oli Bartsch commented on patch set 25 07/30/25, 06:03

    RecordListController.php:118

    Is this necessary? Since 'language' is added as moduelData in the module configuration, this should be handled automatically by `BackendModuleValidator`.

    RecordListController.php:376

    Not sure if this does match here. Have to check.

    DatabaseRecordList.php:778

    Fails if no language capability.

    DatabaseRecordList.php:2508

    Fails if no language capability

    BackendUtility.php:511

    Please no $GLOBAS['TCA'] usage anymore. Use Tca Schema instead.
  1. Fabien Udriot uploaded patch set 26 V -1 10/28/25, 16:15

  2. Fabien Udriot commented on patch set 26 10/28/25, 16:24

    Only resolving conflict / rebasing for now

    RecordListController.php:118 Reply

    Yes, seems so. $this->moduleData->get('language') returned null for me
  3. core-ci voted on patch set 26 V -1 10/28/25, 16:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87860

  4. Fabien Udriot uploaded patch set 27 V -1 10/29/25, 08:51

  5. Fabien Udriot commented on patch set 27 10/29/25, 08:54

    DatabaseRecordList.php:778 Reply

    Done

    DatabaseRecordList.php:2508 Reply

    I would say, it is now resolved with the rebase, as we are checking / wrapping the code with $schema->isLanguageAware()

    BackendUtility.php:511 Reply

    Done
  6. core-ci voted on patch set 27 V -1 10/29/25, 08:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87916

  7. Fabien Udriot uploaded patch set 28 V -1 10/29/25, 11:00

  8. core-ci voted on patch set 28 V -1 10/29/25, 11:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87942

  9. Fabien Udriot uploaded patch set 29 V -1 10/29/25, 11:53

  10. core-ci voted on patch set 29 V +1 10/29/25, 12:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87952

  11. Francois Suter voted on patch set 29 CR +1 V +1 10/29/25, 17:13

  12. Benni Mack commented on patch set 29 10/30/25, 08:56

    RecordListController.php:376 Reply

    Done
  13. Oli Bartsch commented on patch set 29 V -1 10/30/25, 10:32

    The language selection is not stored after going back to the module. It would also be cool to preserve the selected language between page module and list module.
  14. Oli Bartsch uploaded patch set 30 CR +1 V +1 10/30/25, 13:11

  15. core-ci voted on patch set 30 V -1 10/30/25, 13:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88140

  16. Oli Bartsch uploaded patch set 31 V -1 10/30/25, 13:43

  17. core-ci voted on patch set 31 V -1 10/30/25, 13:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88146

  18. Oli Bartsch uploaded patch set 32 V -1 10/30/25, 13:58

  19. Oli Bartsch uploaded patch set 33 10/30/25, 14:06

  20. core-ci voted on patch set 32 V -1 10/30/25, 14:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88147

  21. core-ci voted on patch set 33 V +1 10/30/25, 14:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88152

  22. Oli Bartsch voted on patch set 33 CR +1 V +1 10/30/25, 14:21

  23. Oli Bartsch commented on patch set 33 10/30/25, 14:23

    Reply

    Done
  24. Benni Mack voted on patch set 33 CR +2 V +2 10/30/25, 14:47

  25. Benni Mack merged patch set 34 10/30/25, 14:47