83199[FEATURE] Add language filter for list module
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 10
- typo3/sysext/backend/Classes/Controller/RecordListController.php13+156 −3
- typo3/sysext/backend/Classes/RecordList/DatabaseRecordList.php7+49 −12
- typo3/sysext/backend/Classes/Utility/BackendUtility.php2+14 −4
- typo3/sysext/backend/Configuration/Backend/Modules.php+1 −0
- typo3/sysext/backend/Tests/Functional/Controller/RecordListControllerTest.phpnew+271 −0
- typo3/sysext/backend/Tests/Functional/RecordList/DatabaseRecordListTest.phpnew+193 −0
- typo3/sysext/core/Documentation/Changelog/14.0/Feature-103258-LanguageFilterForListModule.rstnew+74 −0
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/Inline1nCest.php+2 −0
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/InlinePagesLocalizeResourceCest.php+4 −0
- typo3/sysext/core/Tests/Acceptance/Application/RecordList/DatabaseRecordListCest.phpnew+109 −0
Review log 6098
Show 4373 earlier messages
-
Marvin Buchmann uploaded patch set 1 03/04/24, 16:59
-
Marvin Buchmann uploaded patch set 2 03/04/24, 17:05
-
core-ci voted on patch set 1 V -1 03/04/24, 17:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53879
-
Marvin Buchmann rebased onto patch set 3 03/04/24, 17:09
-
core-ci voted on patch set 2 V -1 03/04/24, 17:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53880
-
core-ci voted on patch set 3 V -1 03/04/24, 17:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53881
-
Marvin Buchmann rebased onto patch set 4
V -103/04/24, 18:05 -
core-ci voted on patch set 4 V -1 03/04/24, 18:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53884
-
Marvin Buchmann rebased onto patch set 5
V -103/04/24, 18:13 -
core-ci voted on patch set 5 V -1 03/04/24, 18:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53886
-
Marvin Buchmann uploaded patch set 6
V -103/04/24, 19:07 -
core-ci voted on patch set 6 V -1 03/04/24, 19:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53894
-
Benni Mack commented on patch set 6 03/04/24, 19:15
-
Marvin Buchmann uploaded patch set 7
V -103/04/24, 19:28 -
core-ci voted on patch set 7 V +1 03/04/24, 19:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53897
-
Benni Mack commented on patch set 7 CR -1 03/04/24, 21:20
Feature.rst is missing -
Marvin Buchmann uploaded patch set 8
CR -1V +103/04/24, 21:48 -
core-ci voted on patch set 8 V +1 03/04/24, 21:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53909
-
Josef Glatz commented on patch set 8 03/05/24, 03:32
does such a feature needs specific tests? like e2e or acceptance? -
Benni Mack uploaded patch set 9
V +103/05/24, 11:57 -
Benni Mack commented on patch set 9 03/05/24, 11:58
Reply
I think we should add this, but in a separate patch to also have such Acceptance Tests in the Page Module as well.DatabaseRecordList.php:2403ReplyDone -
Benni Mack voted on patch set 9 CR +1 V +1 03/05/24, 11:59
-
core-ci voted on patch set 9 V -1 03/05/24, 12:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53939
-
Marvin Buchmann uploaded patch set 10
CR +1V +103/05/24, 14:01 -
core-ci voted on patch set 10 V -1 03/05/24, 14:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53948
-
Marvin Buchmann uploaded patch set 11
V -103/05/24, 14:39 -
core-ci voted on patch set 9 V -1 03/05/24, 14:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53939
-
core-ci voted on patch set 11 V -1 03/05/24, 14:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53954
-
Andreas Kienast uploaded patch set 12
V -103/05/24, 15:16 -
Andreas Kienast uploaded patch set 13 03/05/24, 15:17
-
core-ci voted on patch set 12 V -1 03/05/24, 15:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53957
-
core-ci voted on patch set 13 V -1 03/05/24, 15:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53958
-
Marvin Buchmann uploaded patch set 14
V -103/05/24, 15:34 -
core-ci voted on patch set 14 V -1 03/05/24, 15:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53960
-
core-ci commented on patch set 14 03/05/24, 15:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53960
-
core-ci voted on patch set 14 V +1 03/05/24, 15:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53960
-
Benni Mack voted on patch set 14 CR +1 V +1 03/05/24, 16:00
-
Christian Kuhn voted on patch set 14 CR -1 03/05/24, 18:24
-
Josef Glatz wrote 03/06/24, 05:22
Removed cc Josef Glatz. -
Oli Bartsch commented on patch set 14 CR -1 03/06/24, 09:02
RecordListController.php:76I think we don't need this as class property. Also the naming might be improved.RecordListController.php:96I don't see any reason for this method. Let's do the initialization in the `mainAction()`.RecordListController.php:101I think we don't need this as class property. We could just pass the info to the two corresponding methods.RecordListController.php:268I think we should try to optimize this the whole methods code instead of just duplicating it from page module. -
Marvin Buchmann uploaded patch set 15
CR +1V +103/06/24, 14:54 -
Marvin Buchmann commented on patch set 15 03/06/24, 15:00
Reply
@typo3@josefglatz.at I agree. As there are no acceptance tests by now, I added a functional test to check if theRecordListController.php:76ReplyDoneRecordListController.php:96ReplyDoneRecordListController.php:101ReplyDoneRecordListController.php:268ReplyThe method now only fetches page translations for available site languages instead of fetching all existing translations and only using the required ones. Is the "-1" option what should be refactored or which aspect was this aimed at?DatabaseRecordList.php:2403ReplyDone -
core-ci voted on patch set 15 V +1 03/06/24, 15:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54044
-
Marvin Buchmann commented on patch set 15 03/06/24, 15:03
Reply
@typo3@josefglatz.at Sorry, the last message was an earlier draft that Gerrit still had saved and sent now. I just added an acceptance test. -
Marvin Buchmann wrote 03/06/24, 15:03
Removed cc Josef Glatz. -
Guido Schmechel commented on patch set 15 V -1 03/11/24, 20:53
First of all: Nice idea for a feature! Here is some brief feedback from my side 1) When I search for something, my language selection is lost 2) I had created a SysFolder with two categories. One EN (Language UID 0), one NO (Language UID 1). When I filter by EN everything works, with NO the English category is also displayed. -
Marvin Buchmann commented on patch set 15 03/12/24, 06:49
Reply
The idea came from Frank, I guess. 😄 Thanks a lot for testing! I'll see when I can get back to this. Might take a couple of weeks, but I'll check on your feedback as soon as I can! -
Marvin Buchmann uploaded patch set 16
V +104/10/24, 14:03 -
core-ci voted on patch set 16 V -1 04/10/24, 14:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55687
-
Marvin Buchmann commented on patch set 16 04/10/24, 14:28
Reply
1) I just fixed it. 2) Currently it's intended that the default language records are shown as they can be relevant for the translated record (e.g. with fields excluded from translations) - and if there is no translation, one might want to create one. The options in "translate to" are reduced to the filtered language to tidy up the view when there are lots of languages.RecordListController.php:268ReplyJust had another look on this. I think there should be a solution that works across modules. Something like ButtonBar::makeLanguageButton() that centralizes the creation of language selects in the backend. This one is copied from the "page" module, the "view" module for example has another implementation. I guess a separate patch creating a solution that works for all of them would be the way to go. -
Marvin Buchmann uploaded patch set 17
V -104/10/24, 14:46 -
core-ci voted on patch set 17 V +1 04/10/24, 14:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55688
-
Chris Müller uploaded patch set 18
V +105/02/24, 17:51 -
core-ci voted on patch set 18 V -1 05/02/24, 18:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57110
-
core-ci commented on patch set 18 05/03/24, 07:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57110
-
core-ci commented on patch set 18 05/03/24, 09:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57110
-
Chris Müller rebased onto patch set 19
V -105/03/24, 10:17 -
core-ci voted on patch set 19 V -1 05/03/24, 10:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57170
-
Chris Müller rebased onto patch set 20
V -108/01/24, 18:59 -
core-ci voted on patch set 20 V +1 08/01/24, 19:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62611
-
Benni Mack commented on patch set 21
V +109/05/24, 07:55Published edit on patch set 20. -
core-ci voted on patch set 21 V -1 09/05/24, 08:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64842
-
Benni Mack rebased onto patch set 22
V -101/22/25, 08:28 -
core-ci voted on patch set 22 V -1 01/22/25, 08:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72828
-
Benni Mack marked it work in progress 03/28/25, 12:18
-
Benni Mack uploaded patch set 23
V -107/29/25, 21:11 -
Benni Mack commented on patch set 24 07/29/25, 21:16
Published edit on patch set 23. -
Benni Mack rebased onto patch set 25 07/29/25, 21:16
-
Benni Mack marked it ready for review 07/29/25, 21:16
-
core-ci voted on patch set 23 V -1 07/29/25, 21:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82513
-
core-ci voted on patch set 24 V -1 07/29/25, 21:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82514
-
core-ci voted on patch set 25 V -1 07/29/25, 21:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82515
-
Oli Bartsch commented on patch set 25 07/30/25, 06:03
RecordListController.php:118Is this necessary? Since 'language' is added as moduelData in the module configuration, this should be handled automatically by `BackendModuleValidator`.RecordListController.php:376Not sure if this does match here. Have to check.DatabaseRecordList.php:778Fails if no language capability.DatabaseRecordList.php:2508Fails if no language capabilityBackendUtility.php:511Please no $GLOBAS['TCA'] usage anymore. Use Tca Schema instead.
-
Fabien Udriot uploaded patch set 26
V -110/28/25, 16:15 -
Fabien Udriot commented on patch set 26 10/28/25, 16:24
Only resolving conflict / rebasing for nowRecordListController.php:118ReplyYes, seems so. $this->moduleData->get('language') returned null for me -
core-ci voted on patch set 26 V -1 10/28/25, 16:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87860
-
Fabien Udriot uploaded patch set 27
V -110/29/25, 08:51 -
Fabien Udriot commented on patch set 27 10/29/25, 08:54
DatabaseRecordList.php:778ReplyDoneDatabaseRecordList.php:2508ReplyI would say, it is now resolved with the rebase, as we are checking / wrapping the code with $schema->isLanguageAware()BackendUtility.php:511ReplyDone -
core-ci voted on patch set 27 V -1 10/29/25, 08:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87916
-
Fabien Udriot uploaded patch set 28
V -110/29/25, 11:00 -
core-ci voted on patch set 28 V -1 10/29/25, 11:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87942
-
Fabien Udriot uploaded patch set 29
V -110/29/25, 11:53 -
core-ci voted on patch set 29 V +1 10/29/25, 12:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87952
-
Francois Suter voted on patch set 29 CR +1 V +1 10/29/25, 17:13
-
Benni Mack commented on patch set 29 10/30/25, 08:56
RecordListController.php:376ReplyDone -
Oli Bartsch commented on patch set 29 V -1 10/30/25, 10:32
The language selection is not stored after going back to the module. It would also be cool to preserve the selected language between page module and list module. -
Oli Bartsch uploaded patch set 30
CR +1V +110/30/25, 13:11 -
core-ci voted on patch set 30 V -1 10/30/25, 13:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88140
-
Oli Bartsch uploaded patch set 31
V -110/30/25, 13:43 -
core-ci voted on patch set 31 V -1 10/30/25, 13:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88146
-
Oli Bartsch uploaded patch set 32
V -110/30/25, 13:58 -
Oli Bartsch uploaded patch set 33 10/30/25, 14:06
-
core-ci voted on patch set 32 V -1 10/30/25, 14:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88147
-
core-ci voted on patch set 33 V +1 10/30/25, 14:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88152
-
Oli Bartsch voted on patch set 33 CR +1 V +1 10/30/25, 14:21
-
Oli Bartsch commented on patch set 33 10/30/25, 14:23
Reply
Done -
Benni Mack voted on patch set 33 CR +2 V +2 10/30/25, 14:47
-
Benni Mack merged patch set 34 10/30/25, 14:47
DatabaseRecordList.php:2403