Review main Merged

83201[TASK] Centralize logic from PageLayoutController->getExistingPageTranslations() in BackendUtility

Marvin Buchmann CR +2 V +2 Normal +37 −35 updated 03/04/24, 18:34

Commit message

The logic of PageLayoutController->getExistingPageTranslations() was
moved to BackendUtility::getExistingPageTranslations() to make the
code reusable in other places.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Frank Nägler +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Frank Nägler +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 69

  1. Marvin Buchmann uploaded patch set 1 03/04/24, 18:03

  2. Marvin Buchmann uploaded patch set 2 03/04/24, 18:10

  3. core-ci voted on patch set 1 V -1 03/04/24, 18:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53883

  4. core-ci voted on patch set 2 V +1 03/04/24, 18:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53885

  5. Frank Nägler updated the commit message in patch set 3 V +1 03/04/24, 18:17

  6. Frank Nägler voted on patch set 3 CR +1 V +1 03/04/24, 18:21

  7. core-ci voted on patch set 3 V +1 03/04/24, 18:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53887

  8. Stefan Bürk voted on patch set 3 CR +2 V +2 03/04/24, 18:34

  9. Stefan Bürk merged patch set 4 03/04/24, 18:34