83203[TASK] Remove jQuery from EXT:recycler
Commit message
Review
-
Code review CR +2 Done
- Andreas Nedbal +2
- Markus Klein +1
- Andreas Kienast +1
- Benni Mack +1
-
Verified V +2 Done
- Andreas Nedbal +2
- Andreas Kienast +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 6
- Build/Sources/TypeScript/backend/element/pagination.tsrenamed+2 −2
- Build/Sources/TypeScript/recycler/recycler.ts7+175 −202
- Build/Sources/TypeScript/workspaces/backend.ts+2 −2
- typo3/sysext/backend/Resources/Public/JavaScript/element/pagination.jsrenamed+2 −2
- typo3/sysext/recycler/Resources/Public/JavaScript/recycler.js+1 −1
- typo3/sysext/workspaces/Resources/Public/JavaScript/backend.js+1 −1
Review log 2942
Show 1017 earlier messages
-
Andreas Nedbal uploaded patch set 1 03/04/24, 18:58
-
Andreas Nedbal rebased onto patch set 2 03/04/24, 19:05
The following files contain Git conflicts: * typo3/sysext/workspaces/Resources/Public/JavaScript/backend.js -
core-ci voted on patch set 1 V -1 03/04/24, 19:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53891
-
Andreas Nedbal uploaded patch set 3 03/04/24, 19:10
-
Andreas Nedbal marked it ready for review 03/04/24, 19:10
-
core-ci voted on patch set 2 V -1 03/04/24, 19:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53893
-
core-ci voted on patch set 3 V -1 03/04/24, 19:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53895
-
Andreas Nedbal uploaded patch set 4
V -103/04/24, 19:29 -
core-ci voted on patch set 4 V -1 03/04/24, 19:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53898
-
Andreas Nedbal uploaded patch set 5
V -103/04/24, 20:07 -
core-ci voted on patch set 5 V +1 03/04/24, 20:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53903
-
Andreas Nedbal rebased onto patch set 6
V +103/04/24, 20:14The following files contain Git conflicts: * typo3/sysext/workspaces/Resources/Public/JavaScript/backend.js -
Andreas Nedbal uploaded patch set 7 03/04/24, 20:17
-
Andreas Nedbal marked it ready for review 03/04/24, 20:17
-
core-ci voted on patch set 6 V -1 03/04/24, 20:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53904
-
core-ci voted on patch set 7 V +1 03/04/24, 20:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53905
-
Andreas Nedbal commented on patch set 7 03/04/24, 20:31
For people reviewing: filtering by search term seems to be broken in main right now
-
Markus Klein commented on patch set 7 03/04/24, 21:32
recycler.ts:50comment is wrong -
Andreas Nedbal uploaded patch set 8
V +103/04/24, 21:48 -
Andreas Nedbal commented on patch set 8 03/04/24, 21:50
recycler.ts:50ReplyDone. Removed the entire member because it was unused with the refactoring anyway. -
core-ci voted on patch set 8 V +1 03/04/24, 21:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53910
-
Andreas Nedbal rebased onto patch set 9
V +103/05/24, 10:47The following files contain Git conflicts: * typo3/sysext/workspaces/Resources/Public/JavaScript/backend.js -
Andreas Nedbal uploaded patch set 10 03/05/24, 10:50
-
Andreas Nedbal marked it ready for review 03/05/24, 10:50
-
core-ci voted on patch set 9 V -1 03/05/24, 10:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53930
-
core-ci voted on patch set 10 V +1 03/05/24, 10:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53931
-
Andreas Kienast commented on patch set 10 03/05/24, 16:09
recycler.ts:192Since you care for the first parent only, can't you use `target.closest('tr')` instead? -
Andreas Nedbal uploaded patch set 11
V +103/05/24, 16:20 -
Andreas Nedbal commented on patch set 11 03/05/24, 16:21
recycler.ts:192ReplyDone -
core-ci voted on patch set 11 V -1 03/05/24, 16:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53967
-
Andreas Nedbal uploaded patch set 12
V -103/05/24, 16:35 -
core-ci voted on patch set 12 V +1 03/05/24, 16:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53968
-
Andreas Kienast commented on patch set 12 CR -1 03/06/24, 08:40
on it -
Andreas Kienast uploaded patch set 13
CR -1V +103/06/24, 09:26 -
Andreas Kienast voted on patch set 13 CR +1 V +1 03/06/24, 09:26
-
core-ci voted on patch set 13 V +1 03/06/24, 09:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54012
-
Markus Klein commented on patch set 13 03/06/24, 10:23
recycler.ts:165why not using arrow func here? It would be bit more intuitive to read `() => this.undoRecord()` -
Andreas Kienast commented on patch set 13 03/06/24, 10:57
recycler.ts:165ReplyBecause the underlying event API automatically passed event data to the handler. Otherwise, we‘d have to do this manually. -
Markus Klein commented on patch set 13 CR +1 03/06/24, 11:59
recycler.ts:165ReplyAh, good to know. -
Benni Mack voted on patch set 13 CR +1 V +1 03/07/24, 10:01
-
Andreas Nedbal voted on patch set 13 CR +2 V +2 03/07/24, 11:08
-
Andreas Nedbal merged patch set 14 03/07/24, 11:08