Review main Merged

83203[TASK] Remove jQuery from EXT:recycler

Andreas Nedbal CR +2 V +2 Hard +183 −210 updated 03/07/24, 11:08

Commit message

Review

  • Code review CR +2 Done
    • Andreas Nedbal +2
    • Markus Klein +1
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Nedbal +2
    • Andreas Kienast +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 2942

Show 1017 earlier messages
  1. Andreas Nedbal uploaded patch set 1 03/04/24, 18:58

  2. Andreas Nedbal rebased onto patch set 2 03/04/24, 19:05

    The following files contain Git conflicts: * typo3/sysext/workspaces/Resources/Public/JavaScript/backend.js
  3. core-ci voted on patch set 1 V -1 03/04/24, 19:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53891

  4. Andreas Nedbal uploaded patch set 3 03/04/24, 19:10

  5. Andreas Nedbal marked it ready for review 03/04/24, 19:10

  6. core-ci voted on patch set 2 V -1 03/04/24, 19:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53893

  7. core-ci voted on patch set 3 V -1 03/04/24, 19:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53895

  8. Andreas Nedbal uploaded patch set 4 V -1 03/04/24, 19:29

  9. core-ci voted on patch set 4 V -1 03/04/24, 19:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53898

  10. Andreas Nedbal uploaded patch set 5 V -1 03/04/24, 20:07

  11. core-ci voted on patch set 5 V +1 03/04/24, 20:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53903

  12. Andreas Nedbal rebased onto patch set 6 V +1 03/04/24, 20:14

    The following files contain Git conflicts: * typo3/sysext/workspaces/Resources/Public/JavaScript/backend.js
  13. Andreas Nedbal uploaded patch set 7 03/04/24, 20:17

  14. Andreas Nedbal marked it ready for review 03/04/24, 20:17

  15. core-ci voted on patch set 6 V -1 03/04/24, 20:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53904

  16. core-ci voted on patch set 7 V +1 03/04/24, 20:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53905

  17. Andreas Nedbal commented on patch set 7 03/04/24, 20:31

    For people reviewing: filtering by search term seems to be broken in main right now
  1. Markus Klein commented on patch set 7 03/04/24, 21:32

    recycler.ts:50

    comment is wrong
  2. Andreas Nedbal uploaded patch set 8 V +1 03/04/24, 21:48

  3. Andreas Nedbal commented on patch set 8 03/04/24, 21:50

    recycler.ts:50 Reply

    Done. Removed the entire member because it was unused with the refactoring anyway.
  4. core-ci voted on patch set 8 V +1 03/04/24, 21:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53910

  5. Andreas Nedbal rebased onto patch set 9 V +1 03/05/24, 10:47

    The following files contain Git conflicts: * typo3/sysext/workspaces/Resources/Public/JavaScript/backend.js
  6. Andreas Nedbal uploaded patch set 10 03/05/24, 10:50

  7. Andreas Nedbal marked it ready for review 03/05/24, 10:50

  8. core-ci voted on patch set 9 V -1 03/05/24, 10:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53930

  9. core-ci voted on patch set 10 V +1 03/05/24, 10:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53931

  10. Andreas Kienast commented on patch set 10 03/05/24, 16:09

    recycler.ts:192

    Since you care for the first parent only, can't you use `target.closest('tr')` instead?
  11. Andreas Nedbal uploaded patch set 11 V +1 03/05/24, 16:20

  12. Andreas Nedbal commented on patch set 11 03/05/24, 16:21

    recycler.ts:192 Reply

    Done
  13. core-ci voted on patch set 11 V -1 03/05/24, 16:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53967

  14. Andreas Nedbal uploaded patch set 12 V -1 03/05/24, 16:35

  15. core-ci voted on patch set 12 V +1 03/05/24, 16:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53968

  16. Andreas Kienast commented on patch set 12 CR -1 03/06/24, 08:40

    on it
  17. Andreas Kienast uploaded patch set 13 CR -1 V +1 03/06/24, 09:26

  18. Andreas Kienast voted on patch set 13 CR +1 V +1 03/06/24, 09:26

  19. core-ci voted on patch set 13 V +1 03/06/24, 09:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54012

  20. Markus Klein commented on patch set 13 03/06/24, 10:23

    recycler.ts:165

    why not using arrow func here? It would be bit more intuitive to read `() => this.undoRecord()`
  21. Andreas Kienast commented on patch set 13 03/06/24, 10:57

    recycler.ts:165 Reply

    Because the underlying event API automatically passed event data to the handler. Otherwise, we‘d have to do this manually.
  22. Markus Klein commented on patch set 13 CR +1 03/06/24, 11:59

    recycler.ts:165 Reply

    Ah, good to know.
  23. Benni Mack voted on patch set 13 CR +1 V +1 03/07/24, 10:01

  24. Andreas Nedbal voted on patch set 13 CR +2 V +2 03/07/24, 11:08

  25. Andreas Nedbal merged patch set 14 03/07/24, 11:08