Review main Merged

83204[TASK] Replace GeneralUtility::hmac usage in ext:install

Torben Hansen CR +2 V +2 Normal +104 −79 updated 03/05/24, 20:01

Commit message

With #102761, the new `HashService` has been introduced to ensure
that HMAC generation will always use an additional secret. As a
follow-up patch, `GeneralUtility::hmac` will be deprecated when all
usages in the core have been replaced with the new `HashService`.

With this change, usages of `GeneralUtility::hmac` in ext:install are
replaced by the new HashService.

Additionally, we now use DI for `SessionService` in various classes.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 12