Review main Merged

83205[DOCS] Adjust example in changelog for tree node status information

Chris Müller CR +2 V +2 Normal +41 −16 updated 03/05/24, 14:57

Commit message

The example has been adjusted to give an example how this feature
can use for setting the new status information: with a PSR-14 event
listener.

Additionally, use named arguments in the example for tree node labels
for instantiating the DTO.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1319

  1. Chris Müller uploaded patch set 1 03/04/24, 19:37

  2. Chris Müller uploaded patch set 2 03/04/24, 19:38

  3. Chris Müller uploaded patch set 3 03/04/24, 19:39

  4. core-ci voted on patch set 2 V +1 03/04/24, 19:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53900

  5. core-ci voted on patch set 1 V +1 03/04/24, 19:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53899

  6. core-ci voted on patch set 3 V +1 03/04/24, 19:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53901

  7. Chris Müller updated the commit message in patch set 4 V +1 03/04/24, 20:21

  8. core-ci voted on patch set 4 V +1 03/04/24, 20:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53906

  9. Garvin Hicking voted on patch set 4 CR +1 V +1 03/04/24, 22:58

  10. Chris Müller uploaded patch set 5 CR +1 V +1 03/05/24, 08:46

  11. core-ci voted on patch set 5 V +1 03/05/24, 08:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53921

  12. Benjamin Franzke commented on patch set 5 03/05/24, 11:03

    Feature-103186-IntroduceTreeNodeStatusInformation.rst:55

    We'll likely allow (maybe even require) CPP to be used for public promoted properties, therefore we'd really like to keep using CPP in this example code. cc @lolli@schwarzbu.ch
  13. Benjamin Franzke commented on patch set 5 CR -1 03/05/24, 11:16

    Feature-103186-IntroduceTreeNodeStatusInformation.rst:55 Reply

    lolli will explain
  14. Chris Müller uploaded patch set 6 CR -1 V +1 03/05/24, 11:27

  15. Chris Müller commented on patch set 6 03/05/24, 11:28

    Feature-103186-IntroduceTreeNodeStatusInformation.rst:55 Reply

    Done
  16. core-ci voted on patch set 6 V +1 03/05/24, 11:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53936

  17. Garvin Hicking voted on patch set 6 CR +1 V +1 03/05/24, 14:49

  18. Benjamin Franzke commented on patch set 6 CR +2 V +2 03/05/24, 14:57

    Thanks, this is a very helpful improvement for our users!
  19. Benjamin Franzke merged patch set 7 03/05/24, 14:57